Date: Sun, 15 Jun 2014 16:21:01 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: freebsd-ports@freebsd.org, michelle@sorbs.net, lists@opsec.eu Subject: Re: ports/189880: port pgpool-II out of date. Message-ID: <539DB9DD.3050603@FreeBSD.org> In-Reply-To: <20140615142903.GQ2341@home.opsec.eu> References: <201405170220.s4H2K0G0085365@freefall.freebsd.org> <538D0AAE.7090800@sorbs.net> <20140615111101.GM2341@home.opsec.eu> <539DA4F3.2060004@sorbs.net> <20140615142903.GQ2341@home.opsec.eu>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Heh. I was just starting to look at writing a pgpool-II-33 port, but it
seems you have beaten me to it.
On 15/06/2014 15:29, Kurt Jaeger wrote:
> Hi!
>
>>> Second step: merging the diverse set of pgpool related ports into one ?
>
>> Maybe pg-pool-II and pg-pool-devel...? (3.1/2 in stable and 3.3 in
>> devel - until it changes?)
pgpool-II has 3 stable releases at the moment 3.1.10, 3.2.8, 3.3.3
which are all still receiving updates.
> I assume that all the pgpool ports can be consolidated into one (3.3).
>
> Maybe if we start by DEPRECATing the old ones to find out who
> still wants them ? Bcc to kuriyama...
There's a number of things wrong with this port, some inherited from the
pgpool-II port you copied, and some where you're using outmoded constructs.
- You should probably have USES+=pgsql and WANT_PGSQL=client rather
than USE_PGSQL.
- You don't need the empty CONFIGURE_ARGS= and LIB_DEPENDS=
assignments.
- Install docs unconditionally to staging rather than examining the
state of the DOCS option. Whether docs get installed finally is
handled in the post-staging steps.
- Use options helpers rather than if $(PORT_OPTIONS:MFoo). Eg.
instead of
.if ${PORT_OPTIONS:MSSL}
USE_OPENSSL= yes
CONFIGURE_ARGS+=--with-openssl
.endif
use:
SSL_CONFIGURE_WITH= openssl
SSL_USE= OPENSSL=YES
and similarly for the PAM option.
(You used helpers for LIBMEMCACHED stuff but not the others?)
You can then dispense with '.include <bsd.port.options.mk>' line
- The port cannot be staged as a non-root user. This is due to the
way the contrib Makefiles are written -- although elsewhere it
uses standard autoconf stuff, which pretty much just works for
staging purposes.
Probably the best way to fix this is to use ${INSTALL_LIB}
or ${INSTALL_DATA} directly from the port's Makefile and bypass
that install target entirely. It's only 6 files in total
affected by this.
- The .if exists(...) section has the same effect in either branch
of the .if statement. You can just make that bit unconditional
- There's a duplicated entry in the CONFLICTS line
- portlint complains about the wrong sort of whitespace in the
WWW: line in pkg-descr
- You can make libtool automatically strip shared libraries on
installation by adding:
MAKE_ENV= INSTALL_STRIP_FLAG=${STRIP}
This respects local debug settings, so users can build and
install an unstripped version if they so desire.
Cheers,
Matthew
--
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.20 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQJ8BAEBCgBmBQJTnbnwXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NTNBNjhCOTEzQTRFNkNGM0UxRTEzMjZC
QjIzQUY1MThFMUE0MDEzAAoJELsjr1GOGkATrRgP/1o3BiJAnRxxsObr7d/GBSb1
cTZ3QSYgKPDga4t+S8oB0OHYDhYIXCnZ3Jo+OWBYeYb06P16DweNrlWTCNR7+xwf
LomvjMR1mMz8cWkyPfhZdgy0/MFqxtiFdc+vmsi232Xeg7jfoBrIj4PySm5tfjS0
DopJGfQy7V+wvO8GnndUTwQgc/gFrimq3vh6wQRL9gBuiHfZhr79fltOWI2XDMdU
s0RmrO/8VdlPQ/pdfywmONwyJ1pD3eZCT3A/MtwIjOWp841FZX4LqOZaoVs7Hqda
TeQPcRSaNsJXFmyICK/LWQw3BXBVDmMZVjSq4IiFQOoISOExeADzlNI3LHVK7/Qp
AdY/DRIvZQSvaaGfOP4J9kBsA9cVbqJegobAoFCdUdmin/fRpu3NWyCTj3WPjkhj
iqYVon9m7ft5hKFFXxTpWHxsAwdXgl5Pdly4lKym5ZQZpkYoLbcAu6ZrPGKIwKCP
ghGRIWAG5USw81ughgnwX03LFUbufCscCHyruqIDXTKJoy50wMGF8NSGobuX4oxR
DuPfTUGFD0jLUc1GfZ7SnUdUqKTOR0U1kNHyS3lTGLP94Bv3O6+prwycMPztfrZT
vr1aPblOa0ajy358YbdQzgLfUFjlsWE/0TijdLDNhMmpDbabJ/38dWRFnKOFxvb3
0jZ7QbPVuxceYEKfPf6o
=phqV
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?539DB9DD.3050603>