Date: Thu, 3 Dec 2015 11:58:10 -0600 From: Joe Maloney <jmaloney@pcbsd.org> To: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= <jean-sebastien.pedron@dumbbell.fr> Cc: freebsd-current@freebsd.org Subject: Re: EFI and i915kms questions Message-ID: <547D1CBA-AEBD-4A89-91C9-35982D05EF89@pcbsd.org> In-Reply-To: <565EA01E.7000300@dumbbell.fr> References: <54B18FFE-063F-4F62-9343-28FDE68EE358@pcbsd.org> <56505B3F.2070403@dumbbell.fr> <5BC149BC-8BA6-4089-A9E6-763E2494A30A@pcbsd.org> <1736392.rQjToYj3It@ralph.baldwin.cx> <565EA01E.7000300@dumbbell.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
Will give this a try, build an image and report back for sure. Thanks!
Joe Maloney
> On Dec 2, 2015, at 1:39 AM, Jean-S=C3=A9bastien P=C3=A9dron =
<jean-sebastien.pedron@dumbbell.fr> wrote:
>=20
> On 02/12/2015 02:00, John Baldwin wrote:
>> Note that at the top of the function it invokes IICBUS_TRANSFER on a =
different
>> device when force_bit_dev is true:
>>=20
>> 370 sx_xlock(&dev_priv->gmbus_sx);
>> 371 if (sc->force_bit_dev) {
>> 372 dumbbell 282199 error =3D =
-IICBUS_TRANSFER(dev_priv->bbbus[unit], msgs, nmsgs);
>> 373 kib 235783 goto out;
>> 374 }
>>=20
>> Hmm, I would try changing the line at 470 to match the line at 372.
>>=20
>> They used to match, and then this change:
>=20
> You're right. This is something I fixed in my i915 update branch but
> forgot to commit to HEAD...
>=20
> Joe, could you please try what John suggests to confirm?
>=20
> --=20
> Jean-S=C3=A9bastien P=C3=A9dron
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?547D1CBA-AEBD-4A89-91C9-35982D05EF89>