Date: Mon, 06 Apr 2015 19:36:50 -0500 From: Eric Badger <eric@badgerio.us> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: freebsd-current@freebsd.org Subject: Re: Early use of log() does not end up in kernel msg buffer Message-ID: <552326A2.5000406@badgerio.us> In-Reply-To: <70135.1428354681@critter.freebsd.dk> References: <5514CC6D.3020607@badgerio.us> <2033248.Eu3RHS8lTG@ralph.baldwin.cx> <70135.1428354681@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/06/2015 04:11 PM, Poul-Henning Kamp wrote:
> --------
> In message <2033248.Eu3RHS8lTG@ralph.baldwin.cx>, John Baldwin writes:
>
>> I think phk@ broke this back in 70239. Before that the log() function did
>> this:
>>
>> log()
>> {
>>
>> /* log to the msg buffer */
>> kvprintf(fmt, msglogchar, ...);
>>
>> if (!log_open) {
>> /* log to console */
>> kvprintf(fmt, putchar, ...);
>> }
>> }
>>
>> I think your patch is fine unless phk@ (cc'd) has a reason for not wanting to
>> do this.
> The reason was systems not running syslog having slow serial consoles.
>
Correct me if I've misunderstood, but that doesn't seem to matter here;
the proposed change adds logging to the message buffer but leaves
logging to the console (when no syslog is listening) unchanged.
Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?552326A2.5000406>