Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jun 2000 11:23:41 +0200
From:      Sheldon Hearn <sheldonh@uunet.co.za>
To:        Doug Barton <Doug@gorean.org>
Cc:        arch@FreeBSD.org
Subject:   mergemaster: Change in description of envar handling
Message-ID:  <57199.962270621@axl.ops.uunet.co.za>

next in thread | raw e-mail | index | archive | help

Hi Doug,

I'd like to propose a change to the wording of a warning displayed by
mergemaster:

 *** Your PAGER environment variable specifies 'less', but
     I cannot execute it. In general it is good practice to
     specify the full path for environment variables like
     PAGER and EDITOR. Meanwhile, what would you like to do?

  Use 'e' to exit mergemaster and fix your PAGER variable
  Use 'l' to set PAGER to /usr/local/bin/less for this run
  Use 'm' to use plain old 'more' as your PAGER for this run


I understand that mergemaster explicitly overrides the PATH for security
reasons.  I don't want to enter into any discussion of that behaviour
and would ask that readers on the copied mailing list refrain from doing
so.

What I _would_ like to address is the incorrect description of "good
practice" with respect to environment variables.

It is very commonly accepted practice to set EDITOR, PAGER and the like
using partial pathnames.  Look at the default dotfiles in FreeBSD, Linux
and Solaris for proof.  Simply put, mergemaster is out of line with
common practice.

However, as already stated, I do _not_ wish to discuss mergemaster's
handling of the PATH.  You have already presented well-stated
motivations for the way you chose to do that.

Therefore, I would like to reword the warning displayed as follows:

 *** Your PAGER environment variable specifies 'less', but
     I cannot find it in the limited path that I am using.
     What would you like to do?

  Use 'e' to exit mergemaster and change your PAGER variable
  Use 'l' to set PAGER to /usr/local/bin/less for this run
  Use 'm' to use plain old 'more' as your PAGER for this run

Would you be happy with this change?

Ciao,
Sheldon.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57199.962270621>