Date: Sat, 5 Dec 2020 06:42:47 +0000 (UTC) From: Baptiste Daroussin <bapt@FreeBSD.org> To: Thomas Munro <thomas.munro@gmail.com> Cc: Yuri Pankov <yuripv@yuripv.dev>, hackers@freebsd.org Subject: Re: locale-related review, wcwidth() data Message-ID: <5b8f1016-bcb3-42ff-9e70-c4c0240ea685@FreeBSD.org> In-Reply-To: <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com> References: <559840f6-ee81-1303-2986-1eafb2104e1b@yuripv.dev> <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
5 déc. 2020 02:25:29 Thomas Munro <thomas.munro@gmail.com>:
> On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin <bapt@freebsd.org> wrote:
>> I do like what I see here, the only reason I haven't review is that I can't
>> test, since the last modification from hrs@ in the locale generation tools each
>> time I try to regenerate the locales it fails.
>
> During install? I noticed that too but wasn't sure of the correct fix, perhaps:
>
> diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile
> index 76fff6acb17..b6ae2feadac 100644
> --- a/tools/tools/locale/Makefile
> +++ b/tools/tools/locale/Makefile
> @@ -95,7 +95,7 @@ install: install-${t}
> install-${t}:
> cd ${LOCALESRCDIR}/${t} && \
> rm -f Makefile *.src && \
> - install -c ${t}/* ${LOCALESRCDIR}/${t}
> + install -c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t}
> . endif
> .endfor
Nope that one was easy to figure out, but once the locales are regenerated, localdef dies on plenty of them (non unicode mostly).
It does with the current setup as well as with an update of both cldr and un unicode
Best regards,
Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5b8f1016-bcb3-42ff-9e70-c4c0240ea685>