Date: Thu, 20 Dec 2001 20:29:32 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Bruce Evans <bde@zeta.org.au> Cc: Peter Wemm <peter@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c Message-ID: <667.1008876572@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 21 Dec 2001 00:58:35 %2B1100." <20011221005726.Q884-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011221005726.Q884-100000@gamplex.bde.org>, Bruce Evans writes:
>On Wed, 19 Dec 2001, Peter Wemm wrote:
>
>> peter 2001/12/19 21:29:59 PST
>>
>> Modified files:
>> sys/alpha/alpha pmap.c
>> sys/i386/i386 pmap.c
>> sys/ia64/ia64 pmap.c
>> Log:
>> Replace a bunch of:
>> for (pv = TAILQ_FIRST(&m->md.pv_list);
>> pv;
>> pv = TAILQ_NEXT(pv, pv_list)) {
>> with:
>> TAILQ_FOREACH(pv, &m->md.pv_list, pv_list) {
>>
>> Revision Changes Path
>> 1.79 +9 -28 src/sys/alpha/alpha/pmap.c
>> 1.301 +6 -20 src/sys/i386/i386/pmap.c
>> 1.41 +10 -30 src/sys/ia64/ia64/pmap.c
>
>This is a regression IMO. Please write C programs in something
>resembling C.
This is an improvement IMO. Please use whatever means we have to
improve readability of our source code.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?667.1008876572>