Date: Thu, 25 May 2000 23:33:31 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Bruce Evans <bde@zeta.org.au> Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, Jake Burkholder <jburkhol@home.com>, Chuck Robey <chuckr@picnic.mat.net>, FreeBSD-current <current@FreeBSD.ORG> Subject: Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h uthread_file.c src/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ... Message-ID: <6979.959290411@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 25 May 2000 01:20:05 %2B1000." <Pine.BSF.4.21.0005250102020.2774-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.21.0005250102020.2774-100000@besplex.bde.org>, Bruce Evans
writes:
>On Wed, 24 May 2000, Garrett Wollman wrote:
>
>> <<On Tue, 23 May 2000 20:27:10 -0700, Jake Burkholder <jburkhol@home.com> said:
>>
>> > I've just built a fresh world here; if you use the cvs-crypto from
>> > internat, it may be broken. I submitted a patch to Mark Murray which
>> > should fix it, here it is again just in case:
>>
>> I still think (and am going on record) that this is a REALLY, REALLY
>> BAD idea.
>
>Especially since most of the queue macros require the type to be a struct
>to work. E.g.:
>
>#define SLIST_REMOVE(head, elm, type, field) do { \
> ^^^^ a supposedly general type
> if (SLIST_FIRST((head)) == (elm)) { \
> SLIST_REMOVE_HEAD((head), field); \
> } \
> else { \
> type *curelm = SLIST_FIRST((head)); \
> while (SLIST_NEXT(curelm, field) != (elm)) \
> ^^^^^^^^^^^^^^^^^^^^^^^^^
>
>I objected to a recent commit hiding the fact that this is
>"(elm)->field.sle_next". Anyway, curelm must be a pointer to a struct.
>Not just any struct; the struct must contain a "field" declared using
>SLIST_ENTRY().
It could be an union or class as well...
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD coreteam member | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6979.959290411>