Date: Sun, 23 Mar 2008 15:54:32 +0800 From: "Rong-en Fan" <grafan@gmail.com> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: perl@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: [PATCH] archivers/p5-Compress-LZW: CPAN Macro Message-ID: <6eb82e0803230054p657679bdxbc7f483a3ad1df7d@mail.gmail.com> In-Reply-To: <200803230517.m2N5Hw6v070612@piccollo.p6m7g8.net> References: <200803230517.m2N5Hw6v070612@piccollo.p6m7g8.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 23, 2008 at 1:17 PM, Philip M. Gollucci
<pgollucci@p6m7g8.com> wrote:
>
> >Submitter-Id: current-users
> >Originator: Philip M. Gollucci
> >Organization: Riderway Inc.
> >Confidential: no
> >Synopsis: [PATCH] archivers/p5-Compress-LZW: CPAN Macro
> >Severity: non-critical
> >Priority: low
> >Category: ports
> >Class: change-request
> >Release: FreeBSD 8.0-CURRENT i386
> >Environment:
> System: FreeBSD piccollo.p6m7g8.net 8.0-CURRENT FreeBSD 8.0-CURRENT #1: Sun Mar 2 09:48:59 EST
> >Description:
>
> Port maintainer (perl@FreeBSD.org) is cc'd.
>
> Generated with FreeBSD Port Tools 0.77
> >How-To-Repeat:
> >Fix:
>
> --- p5-Compress-LZW-0.01_1.patch begins here ---
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/ports/archivers/p5-Compress-LZW/Makefile,v
> retrieving revision 1.4
> diff -u -u -r1.4 Makefile
> --- Makefile 8 Sep 2007 00:51:17 -0000 1.4
> +++ Makefile 22 Mar 2008 20:32:24 -0000
> @@ -9,7 +9,7 @@
> PORTVERSION= 0.01
> PORTREVISION= 1
> CATEGORIES= archivers perl5
> -MASTER_SITES= ${MASTER_SITE_PERL_CPAN}
> +MASTER_SITES= CPAN
> MASTER_SITE_SUBDIR= Compress
> PKGNAMEPREFIX= p5-
First, when you using CPAN, it has SUBDIR set to the correct
directory if you use module's name as PORTNAME. Second,
I'm not sure if this is a good idea to that just switch to the macro
without any version update. Usually, maintainers change to use
macros in bsd.sites.mk when there is new version available.
If perl@ thinks that we are going to use CPAN macro by default,
then perhaps change all perl@ maintained ports at once will
be better.
Regards,
Rong-En Fan
>
> --- p5-Compress-LZW-0.01_1.patch ends here ---
>
> _______________________________________________
> freebsd-perl@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-perl
> To unsubscribe, send any mail to "freebsd-perl-unsubscribe@freebsd.org"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6eb82e0803230054p657679bdxbc7f483a3ad1df7d>