Date: Wed, 13 Jan 2016 22:43:37 +0100 From: Nikola Pajkovsky <n.pajkovsky@gmail.com> To: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= <jean-sebastien.pedron@dumbbell.fr> Cc: freebsd-x11@freebsd.org Subject: Re: build-able drm-i915-update-38 Message-ID: <864mehduk6.fsf@freebsd.lan> In-Reply-To: <5696A19A.2030009@dumbbell.fr> (=?utf-8?Q?=22Jean-S=C3=A9bast?= =?utf-8?Q?ien_P=C3=A9dron=22's?= message of "Wed, 13 Jan 2016 20:12:26 %2B0100") References: <87oacpdguk.fsf@gooddata.com> <5696A19A.2030009@dumbbell.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
Jean-S=C3=A9bastien P=C3=A9dron <jean-sebastien.pedron@dumbbell.fr> writes:
> On 13/01/2016 09:27, Nikola Pajkovsky wrote:
>> I was trying build HEAD drm-i915-update-38, and I found it, it does not
>> build. Can we please push only changes, which does build?
>
> Hi!
>
> I rebuild a full kernel from scratch and it does build fine here. There
> is no "unused variable" warning for me. Do you build a non-debug kernel
> perhaps? I don't plan to build-test such a kernel now, I'll do it when
> the patch is finished.
Oh, everytime? I have found out, that
$ cd sys/modules/drm2
$ make -j9
$ make DESTDIR=3D/boot/ KMODDIR=3Dkernel.i915 install
is engough (only after I have fully built and booted kernel)
=3D=3D=3D> drm2 (all)
Warning: Object directory not changed from original /usr/home/npa/freebsd-b=
ase-graphics/sys/modules/drm2/drm2
=3D=3D=3D> i915kms (all)
Warning: Object directory not changed from original /usr/home/npa/freebsd-b=
ase-graphics/sys/modules/drm2/i915kms
cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc=
-I. -I/usr/home/npa/freebsd-base-graphics/sys/modules/drm2/i915kms/../..=
/.. -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcm=
odel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchrono=
us-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant=
-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer=
-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=3D__fre=
ebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unkn=
own-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-er=
ror-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sig=
n -Wno-error-shift-negative-value -mno-aes -mno-avx -std=3Diso9899:1999 -=
c /usr/home/npa/freebsd-base-graphics/sys/modules/drm2/i915kms/../../../dev=
/drm2/i915/i915_gem_gtt.c -o i915_gem_gtt.o
/usr/home/npa/freebsd-base-graphics/sys/modules/drm2/i915kms/../../../dev/d=
rm2/i915/i915_gem_gtt.c:451:12: error: unused variable 'max_entries' [-Werr=
or,-Wunused-variable]
const int max_entries =3D dev_priv->mm.gtt->gtt_total_entries - fir=
st_entry;
^
1 error generated.
*** Error code 1
code in i915_gem_gtt.c
gen6_ggtt_bind_object()
const int max_entries =3D dev_priv->mm.gtt->gtt_total_entries - first_e=
ntry;
BUG_ON(i > max_entries);
Seems like BUG_ON is noop, which should not be.
>> I can send you patch to fix it later on today. I'm going to try start
>> syncing drm with v3.9 today. Where do you want me to send patches,
>> freebsd-x11 or pull request in github?
>
> For the warning, it can be a pull request on the drm-i915-update-38
> branch. I will create drm-next-3.9 branch too for you to start.
Ok, thanks.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864mehduk6.fsf>