Date: Fri, 06 Mar 2026 16:05:25 -0400 From: Joseph Mingrone <jrm@freebsd.org> To: Daniel Engberg <diizzy@FreeBSD.org> Cc: Robert Clausecker <fuz@fuz.su>, Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8bd89ab595cb - main - deskutils/qownnotes: the port had been updated to version 26.3.3 Message-ID: <867bro4tbu.fsf@asn.ftfl.ca> In-Reply-To: <0d07fa34-2f60-4d6d-bc68-3dc1ba73cd33@FreeBSD.org> References: <69aa7cc7.1e357.86a2325@gitrepo.freebsd.org> <d9c764b0-d7ac-42b6-b7dc-749f78c34cdd@FreeBSD.org> <aasdUKj2kE21pwRo@FreeBSD.org> <467d5bb3-f7ac-4733-98b4-b011050b5aae@FreeBSD.org> <aassu2ParRY3_paB@fuz.su> <0d07fa34-2f60-4d6d-bc68-3dc1ba73cd33@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, 2026-03-06 at 20:41, Daniel Engberg <diizzy@FreeBSD.org> wrote: > On 2026-03-06 20:36, Robert Clausecker wrote: >> Hi Daniel, >> Am Fri, Mar 06, 2026 at 08:27:24PM +0100 schrieb Daniel Engberg: >>> On 2026-03-06 19:30, Alexey Dokuchaev wrote: >>>> On Fri, Mar 06, 2026 at 05:50:56PM +0100, Daniel Engberg wrote: >>>>> On 2026-03-06 08:05, Alexey Dokuchaev wrote: >>>>>> commit 8bd89ab595cb9f03ab29068b1a0c08795d438781 >>>>>> deskutils/qownnotes: the port had been updated to version 26.3.3 >>>>>> Reduce vertical space to help Makefile maintainability by merging >>>>>> sporadic use of helpers and two per-flavor conditionals into one; >>>>>> drop needless default flavor assignment. >>>>> You've now introduced more regressions (check portlint) and review >>>>> https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-using . >>>>> Please fix your commit or back it out. >>>> There's nothing to fix, it looks exactly how I want it to look without >>>> impeding future updates which I've been doing for past five years, as >>>> de jure maintainer is inactive. I believe I've provided sufficient >>>> explanation in the commit log why I dislike scattering stuff belonging >>>> to one flavor around several places. >>>> I appreciate your attention to detail, but rigorously obeying lint tools >>>> and general guidelines when they pessimize things more than do any good >>>> is bad engineering practice. >>>> ./danfe >>> If you're intentionally introducing more regressions into the tree it's >>> clearly not going to in the right direction. Does that mean people can take >>> over your ports whenever they feel like it? >> Please remember that portlint warnings are warnings and not errors for >> a reason. What portlint recommends is more of a guideline than a hard >> and fast rule, and committers can decide to go against these recommendations >> if they believe that to be a reasonable choice. >> Please stop badgering committers for violations of rules you have made up. >> Adding a change that introduces a portlint warning is not a regression. >> Yours, >> Robert Clausecker > You've been wrong on multiple occasions so please read up instead of jumping in just for the sake of it. You've already made it quite clear on about your standards. It clearly diverges from Porters Handbook AND introduces regressions. What exactly is a regression in this case? If you're demanding that someone else's work be backed out, please provide specific examples. I tend to prefer standardized formatting since it makes automating large changes easier, but I agree with others that these are guidelines and shouldn't be treated as rules set in stone. If this is just a formatting change and the person effectively maintaining the port is more comfortable with the current layout, why is it such a problem? Joe [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmmrM4VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvngmFD/9ki6sCrnuGOzhFhH2QXEECW+veMDxzf/Vl Q88OjS3i1x+x+gapfIX9L/ZyTUZzV+On2n7KNmO2Wy9gCz2Iz67eNuObBha0/lgi AoSte1c90x7RsgaSp3oqxTRpiRC8vLQSCgi59HGxMCZ7bFLprt7Sb5sql9aOjrsV PNlRrhQe7ivGLJL8iVEBhTYdDN/I1M9o1dWbyyN+0QtEovJZVm32JF3AkTZXK3lv xUKVBDTb3QoDxk1ioXzLXsDeagFeIuFC0uRpSOL40YpQn7RcQe6vEJayaPXAOZhm mfozJz4mwhcdq5ODGNYgFwa9I+j5YWo9oRE9/Zy/zs8NFINodmInjdON8EzGdHX8 PxeufH+R9KRz0inCxG3AMd19aApT8VlNdvQoW567iOyoKkLvBeqjKIjFszEyib8q rQjYONOoCAP3L26+vrV1E24oPAYQR02gNMg0v9NHdPCljzQ47GJJ+3fyoClej7VA OxKoupHd2WimM26KZE1AaowVqbrFQUOvBnz+ARaRMjM8K+BFE5yyVvX+Yf+pcz/o RGDsbRzBICfD7/oMaNhbg6u329G84Kn5u3wPp856m8WBQ4mHQrW+e6j9ZVU5Gabw ru0OoS4DbT4+P9+c/80RlsqNohH5TfYG1RnTo7j9I2GCLvkHbOnc3AeB1Pk2mi7F Vb9C56XjNQ== =rBU8 -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867bro4tbu.fsf>