Date: Wed, 21 Jan 2009 17:25:45 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: "Andrew Brampton" <brampton+freebsd-fs@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: Pseudofs and pfs_attr_t for non-process based files Message-ID: <868wp4pqwm.fsf@ds4.des.no> In-Reply-To: <d41814900901181701n7928e40cv2aa1dc4dff582fda@mail.gmail.com> (Andrew Brampton's message of "Mon, 19 Jan 2009 01:01:36 %2B0000") References: <d41814900901181701n7928e40cv2aa1dc4dff582fda@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"Andrew Brampton" <brampton+freebsd-fs@gmail.com> writes: > Basically pn_attr calls my pfs_attr_t function pointer, but only if > the proc !=3D null. Now in my case none of my files are created > PFS_PROCDEP flag, which mean proc will always be null. So unless you > are writing a pseudofs which is dependent on the process calling it, > you cannot use a pfs_attr_t function pointer, meaning I can't change > the attributes on my pseudo files. > > Now, to fix this problem I made a very simple patch which will call > pn_attr regardless of proc being null or not. By doing this I had to > also make a minor change in procfs.c as it assumes a valid proc is > always passed in. Sounds sensible, but your patches are mangled. Could you please regenerate them using 'svn diff -x-p' on a non-Windows machine? DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?868wp4pqwm.fsf>