Date: Sun, 23 Dec 2007 10:40:39 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Ed Maste <emaste@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: config(8) patch for review for src dir handling Message-ID: <86ejddg354.fsf@ds4.des.no> In-Reply-To: <20071219222621.GA79432@sandvine.com> (Ed Maste's message of "Wed\, 19 Dec 2007 17\:26\:21 -0500") References: <20071219222621.GA79432@sandvine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ed Maste <emaste@freebsd.org> writes:
> Right now config(8) calls realpath("../..", ... to find the src path
> to write into the kernel Makefile. I want to change this to use $PWD
> with the last two path components removed, assuming it's the same dir
> as ../.. .
I'm worried that your patch assumes that $PWD is present and correct,
for which there is no guarantee. What happens if you use getcwd()
instead of getenv("PWD")?
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ejddg354.fsf>