Date: Mon, 30 Apr 2001 17:35:46 +0900 From: "Akinori MUSHA" <knu@iDaemons.org> To: Kris Kennaway <kris@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/fox/files patch-ad Message-ID: <86elua4wf1.wl@archon.local.idaemons.org> In-Reply-To: <200104300810.f3U8AGY60114@freefall.freebsd.org> References: <200104300810.f3U8AGY60114@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Mon, 30 Apr 2001 01:10:16 -0700 (PDT),
kkenn wrote:
> kris 2001/04/30 01:10:16 PDT
>
> Modified files:
> x11-toolkits/fox/files patch-ad
> Log:
> Don't hard-code -O2 and various -f optimizations in CXXFLAGS
>
> Revision Changes Path
> 1.2 +37 -5 ports/x11-toolkits/fox/files/patch-ad
Thanks, but I wasn't asked for a review in advance on this... At a
glance, I noticed that /usr/local was hardcoded, which might be evil.
Also, I haven't yet tested if this big monster of a toolkit works with
optimization flags other than "-O2 -ffast-math -finline-functions
-fomit-frame-pointer -fexpensive-optimizations". I wish you had
pointed it to me rather than just committing directly.
I am going to test it out soon and in any case I will put those
default flags in the Makefile in a comment as recommendation,
--
/
/__ __ Akinori.org / MUSHA.org
/ ) ) ) ) / FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp
"Freeze this moment a little bit longer, make each impression
a little bit stronger.. Experience slips away -- Time stand still"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86elua4wf1.wl>