Date: Mon, 20 Oct 2025 18:42:06 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Ryan Libby <rlibby@gmail.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 195b00ec45e5 - main - quot: Clean up Message-ID: <86h5vt4ja9.fsf@ltc.des.dev> In-Reply-To: <CAHgpiFyQiBBiMGSND-fuALVxou3Ab9%2Bbc3zj2ZC%2BHKTPySVysA@mail.gmail.com> (Ryan Libby's message of "Fri, 17 Oct 2025 15:01:04 -0700") References: <202510171155.59HBtMCp004658@gitrepo.freebsd.org> <CAHgpiFyQiBBiMGSND-fuALVxou3Ab9%2Bbc3zj2ZC%2BHKTPySVysA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
Ryan Libby <rlibby@gmail.com> writes: > Dag-Erling Smørgrav <des@freebsd.org> writes: >> In function 'usrrehash', >> inlined from 'user' at /workspace/src/usr.sbin/quot/quot.c:244:3: >> /workspace/src/usr.sbin/quot/quot.c:210:22: error: argument 1 range [18446744071562067968, 18446744073709551615] exceeds maximum object size 9223372036854775807 [-Werror=alloc-size-larger-than=] >> 210 | if ((users = calloc(nusers, sizeof(*users))) == NULL) >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from /workspace/src/usr.sbin/quot/quot.c:51: >> /tmp/obj/workspace/src/amd64.amd64/tmp/usr/include/stdlib.h: In function 'user': >> /tmp/obj/workspace/src/amd64.amd64/tmp/usr/include/stdlib.h:92:10: >> note: in a call to allocation function 'calloc' declared here >> 92 | void *calloc(size_t, size_t) __malloc_like __result_use_check >> | ^~~~~~ > > Probably it is from > -WARNS?= 2 > > I think gcc is saying that it thinks nusers may be negative. It's saying nusers may be large enough that the result of multiplying it by sizeof(*users) exceeds an arbitrary threshold, which is technically true but completely unhelpful. This gcc option should not be used. DES -- Dag-Erling Smørgrav - des@FreeBSD.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86h5vt4ja9.fsf>