Date: Wed, 30 Jul 2008 08:49:55 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: arch@freebsd.org Cc: kan@freebsd.org, pjd@freebsd.org Subject: Re: Need a code review Message-ID: <86r69buar0.fsf@ds4.des.no> In-Reply-To: <20080729.161303.709402272.imp@bsdimp.com> (M. Warner Losh's message of "Tue\, 29 Jul 2008 16\:13\:03 -0600 \(MDT\)") References: <20080729.161303.709402272.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"M. Warner Losh" <imp@bsdimp.com> writes: > http://people.freebsd.org/~gonzo/mips2/libpam.diff This won't work. Your patch unconditionally sets NO_STATIC_MODULES which will result in a non-functional libpam.a (the modules will be built into the library, but without any of the glue that allows the library to find them) not just on mips, but on all other platforms. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86r69buar0.fsf>