Date: Fri, 03 Jul 2026 08:26:13 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Yuri Victorovich <yuri@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: a816f578c1dc - main - science/py-tweedledum: update 1.1.1-20221123 =?utf-8?Q?=E2=86=92?= 1.2.0 Message-ID: <86v7aw7fne.fsf@ltc.des.dev> In-Reply-To: <fbe71b44-0fce-4aa3-8771-bd82408eee5d@FreeBSD.org> (Yuri Victorovich's message of "Thu, 2 Jul 2026 22:05:07 -0700") References: <6a46a5b1.2276e.226b6bfe@gitrepo.freebsd.org> <86zf096tnc.fsf@ltc.des.dev> <fbe71b44-0fce-4aa3-8771-bd82408eee5d@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Yuri Victorovich <yuri@FreeBSD.org> writes: > Dag-Erling Smørgrav <des@FreeBSD.org> writes: > > Why did you commit an old and incorrect version of this patch instead of > > just approving the review, or committing the patch from the review? > The Bugzilla issue is not linked to the review so I didn't notice it. Yes it was, and you received several emails about it, which you ignored, just like you ignored the complaints when you broke Gnome last week. > The review has DISTVERSIONSUFFIX=-20260518 which is a minor thing and > I don't think it should be in the port. You're wrong, it was essential, because now there is no way to distinguish this version, built from a specific pre-release commit, from a later version built from a different pre-release commit, or from the actual 1.2.0 release. DES -- Dag-Erling Smørgrav - des@FreeBSD.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86v7aw7fne.fsf>