Date: Sat, 26 Nov 2016 02:00:13 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Mark Millard <markmi@dsl-only.net> Cc: svn-ports-head@freebsd.org, FreeBSD Ports <freebsd-ports@freebsd.org>, Gerald Pfeifer <gerald@FreeBSD.org> Subject: Re: svn commit: r427110 - head/lang/gcc/files [does lang/gcc49 need such too?] Message-ID: <9D54F0CC-F38C-4CCE-BC33-25C1457BD44B@FreeBSD.org> In-Reply-To: <86C72DB2-B9ED-4512-A88C-BD1D9A23806F@dsl-only.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 26 Nov 2016, at 01:13, Mark Millard <markmi@dsl-only.net> wrote: > >> Author: dim (src committer) >> Date: Fri Nov 25 12:54:01 2016 >> New Revision: 427110 >> URL: >> https://svnweb.freebsd.org/changeset/ports/427110 >> >> >> Log: >> Fix build of lang/gcc with libc++ 3.9.0, similar to r421625: >> . . . >> What is happening here, is that the source file includes gcc/system.h, >> which defines abort to fancy_abort, and then the source file includes >> <new>, which attempts to call _VSTD::abort() (the _VSTD is a libc++ >> alias for std::). The macro definition then causes the above breakage. >> >> Newer gcc ports, such as gcc5 and gcc6 don't show this issue, because >> upstream gcc first added an include of <algorithm> (which indirectly >> includes <new>) in r217348 [1], and later even add a direct include of >> <new> in r232736 [2]. >> >> Fix it for this version, by adding the direct include of <new> to >> gcc/system.h. This makes the 'second' includes of <new> in some .c >> files superfluous, but at least they won't result in errors. > > Will lang/gcc49 needs similar changes? Actually, the patch was copied from the lang/gcc49 port, which had already been fixed earlier, in r421625. > (I normally only use explicitly version numbered lang/gcc* 's and > I use lang/gcc49 on powerpc64's.) Well, lang/gcc is a special case, in the sense that some ports that have USE_GCC=yes, e.g. with an unspecified version, will default to it. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlg43qQACgkQsF6jCi4glqPXEQCbBTGHAybQmC1tvyoaJL/ORQPq atYAoOQ8N2gcwjeY/xP4W7B+oCCenarA =f8bk -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9D54F0CC-F38C-4CCE-BC33-25C1457BD44B>