Date: Sun, 21 Nov 2010 23:18:59 +0000 From: Paul B Mahol <onemda@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: hackers@freebsd.org Subject: Re: Remove printf in acpi_tz_sanity() Message-ID: <AANLkTimJuq57mzAyb%2BaZ8imrW0cc4qNbZ0FL4_i=3ub9@mail.gmail.com> In-Reply-To: <4CE98C7E.90301@freebsd.org> References: <AANLkTimThbVyXmgU76m44GTzR0qGAQuJt-9xwunP-QdQ@mail.gmail.com> <4CE98C7E.90301@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon <avg@freebsd.org> wrote:
> on 21/11/2010 13:07 Paul B Mahol said the following:
>> This patch removes printf which spams console whenever thermal state
>> is changed in laptop. Source of problem is in buggy BIOS.
>>
>> diff --git a/sys/dev/acpica/acpi_thermal.c b/sys/dev/acpica/acpi_thermal=
.c
>> index 515a742..00866b2 100644
>> --- a/sys/dev/acpica/acpi_thermal.c
>> +++ b/sys/dev/acpica/acpi_thermal.c
>> @@ -697,11 +697,8 @@ acpi_tz_getparam(struct acpi_tz_softc *sc, char
>> *node, int *data)
>> =A0static void
>> =A0acpi_tz_sanity(struct acpi_tz_softc *sc, int *val, char *what)
>> =A0{
>> - =A0 =A0if (*val !=3D -1 && (*val < TZ_ZEROC || *val > TZ_ZEROC + 2000)=
) {
>> - =A0 =A0 device_printf(sc->tz_dev, "%s value is absurd, ignored (%d.%dC=
)\n",
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 what, TZ_KELVTOC(*val));
>> + =A0 =A0if (*val !=3D -1 && (*val < TZ_ZEROC || *val > TZ_ZEROC + 2000)=
)
>> =A0 =A0 =A0 *val =3D -1;
>> - =A0 =A0}
>> =A0}
>
> As is - this is a perfect candidate for a "local only" patch.
> To be included into the tree - this, most probably, has to be controlled =
by a
> tunable/sysctl.
So solution for useless console spamming is to add useless sysctl.
For -1 values, sane default values should be picked up.
Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for tz0=
.
I'm not first one mentioning this and issue is old several years.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimJuq57mzAyb%2BaZ8imrW0cc4qNbZ0FL4_i=3ub9>