Date: Thu, 31 May 2001 14:30:21 -0400 From: Mike Barcroft <mike@q9media.com> To: Mike Heffner <mheffner@vt.edu> Cc: <phk@freebsd.org>, <freebsd-audit@freebsd.org> Subject: Re: whois(1) patch Message-ID: <B73C05FD.BD5%mike@q9media.com> In-Reply-To: <XFMail.20010530223446.mheffner@novacoxmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/30/01 10:34 PM, Mike Heffner at mheffner@novacoxmail.com wrote: > On 29-May-2001 Mike Barcroft wrote: > | > | Please review the patch at the following URL: > | http://testbed.q9media.net/freebsd/whois.patch > | > | > | It does the following: > | > | o Silence warnings and set WARNS=2 > | o Fix two memory leaks > | o asprint -> strdup where appropriate > | o calloc/strcpy/strcat -> aprintf > | o Convert to ANSI C to avoid having to prototype main() > > You don't need the space between (void) and asprintf(). Also, I think dd had a > patch for gcc to quiet the warning about main() not having a prototype, so I > don't know if the ANSI-fication is truly needed. Otherwise, looks alright ;) Oops, how'd that space sneak in there. I've removed the space from the patch. I must be spending too much time looking at sendmail's source. :) I originally made the ANSI C change to silence a warning, but is there any reason not to bring the code up to ANSI C spec? Is it likely that anyone will need to compile whois with a K&R compiler? Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B73C05FD.BD5%mike>