Date: Fri, 22 Jun 2001 12:32:26 -0400 From: Mike Barcroft <mike@q9media.com> To: <obrien@freebsd.org> Cc: Mike Heffner <mheffner@vt.edu>, <phk@freebsd.org>, <freebsd-audit@freebsd.org> Subject: Re: whois(1) patch Message-ID: <B758EB5A.D6C%mike@q9media.com> In-Reply-To: <20010622033201.B506@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/22/01 6:32 AM, David O'Brien at obrien@freebsd.org wrote:
> You should separate your patches into functionality and style(9).
> I see DES just committed this patch as is, rather than break it into two
> parts as our practices says it should have been.
Sorry. I'll make sure I do this in future.
> You also changed puts() to printf(). Was there a reason for making that
> change?
style(9):
Use printf(3), not fputs/puts/putchar/whatever; it's faster and usually
cleaner, not to mention avoiding stupid bugs.
Best regards,
Mike Barcroft
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B758EB5A.D6C%mike>