Date: Tue, 19 Apr 2011 09:44:50 -0700 From: mdf@FreeBSD.org To: Taku YAMAMOTO <taku@tackymt.homeip.net> Cc: freebsd-current@freebsd.org, Nick Ulen <uncle@wolfman.devio.us> Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared Message-ID: <BANLkTi=YjVLKXDkogETYmG2M7AjkLZo6ew@mail.gmail.com> In-Reply-To: <20110419234815.e2944dd5.taku@tackymt.homeip.net> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <BANLkTim=M=JeOn8iSgfnhT-Q0dX=QfYLuw@mail.gmail.com> <20110419082906.GA8125@wolfman.devio.us> <20110419234815.e2944dd5.taku@tackymt.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Tue, Apr 19, 2011 at 7:48 AM, Taku YAMAMOTO <taku@tackymt.homeip.net> wrote:
>> This patch works.
>>
>> FreeBSD 9.0-CURRENT #1: Tue Apr 19 10:52:58 MSD 2011
>>
>> # sysctl hw.acpi.thermal
>> hw.acpi.thermal.min_runtime: 0
>> hw.acpi.thermal.polling_rate: 10
>> hw.acpi.thermal.user_override: 0
>> hw.acpi.thermal.tz0.temperature: 67.5C
>> hw.acpi.thermal.tz0.active: -1
>> hw.acpi.thermal.tz0.passive_cooling: 0
>> hw.acpi.thermal.tz0.thermal_flags: 0
>> hw.acpi.thermal.tz0._PSV: -1
>> hw.acpi.thermal.tz0._HOT: -1
>> hw.acpi.thermal.tz0._CRT: 90.0C
>> hw.acpi.thermal.tz0._ACx: -1
>> hw.acpi.thermal.tz0._TC1: -1
>> hw.acpi.thermal.tz0._TC2: -1
>> hw.acpi.thermal.tz0._TSP: -1
>
> We should have 10 _ACx values like this:
> hw.acpi.thermal.tz0._ACx: -1 -1 -1 -1 -1 -1 -1 -1 -1 -1
D'oh, I didn't read the original source carefully enough.
Can someone test this patch? As an aside, what kind of h/w do I need
for hw.acpi.thermal to show up? I don't see it on my Dell desktop...
Thanks,
matthew
[-- Attachment #2 --]
diff --git a/sys/dev/acpica/acpi_thermal.c b/sys/dev/acpica/acpi_thermal.c
index b64d8df..7226b6c 100644
--- a/sys/dev/acpica/acpi_thermal.c
+++ b/sys/dev/acpica/acpi_thermal.c
@@ -288,7 +288,8 @@ acpi_tz_attach(device_t dev)
"critical temp setpoint (shutdown now)");
SYSCTL_ADD_PROC(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysctl_tree),
OID_AUTO, "_ACx", CTLTYPE_INT | CTLFLAG_RD,
- &sc->tz_zone.ac, 0, sysctl_handle_int, "IK", "");
+ &sc->tz_zone.ac, sizeof(sc->tz_zone.ac),
+ sysctl_handle_opaque, "IK", "");
SYSCTL_ADD_PROC(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysctl_tree),
OID_AUTO, "_TC1", CTLTYPE_INT | CTLFLAG_RW,
sc, offsetof(struct acpi_tz_softc, tz_zone.tc1),
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=YjVLKXDkogETYmG2M7AjkLZo6ew>