Date: Thu, 12 Sep 2013 06:48:42 -0400 From: Dheeraj Kandula <dkandula@gmail.com> To: Alfred Perlstein <bright@mu.org> Cc: freebsd-arch@freebsd.org Subject: Re: Why do we need to acquire the current thread's lock before context switching? Message-ID: <CA%2BqNgxS7RHj2LpdyADhgyjSDYfZDJODgyjV4m1yT6o5DchHQ-w@mail.gmail.com> In-Reply-To: <523168EE.4070508@mu.org> References: <CA%2BqNgxSVkSi88UC3gmfwigmP0UCO6dz%2B_Zxhf_=URK7p4c-Ghg@mail.gmail.com> <523168EE.4070508@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks a lot Alfred for the clarification. So is the td_lock granular i.e. one separate lock for each thread but also used for protecting the scheduler variables or is it just one lock used by all threads and the scheduler as well. I will anyway go through the code that you suggested but just wanted to have a deeper understanding before I go about hunting in the code. Dheeraj On Thu, Sep 12, 2013 at 3:10 AM, Alfred Perlstein <bright@mu.org> wrote: > On 9/11/13 2:39 PM, Dheeraj Kandula wrote: > >> Hey All, >> >> When the current thread is being context switched with a newly selected >> thread, why is the current thread's lock acquired before context switch = =96 >> mi_switch() is invoked after thread_lock(td) is called. A thread at any >> time runs only on one of the cores of a CPU. Hence when it is being >> context >> switched it is added either to the real time runq or the timeshare runq = or >> the idle runq with the lock still held or it is added to the sleep queue >> or >> the blocked queue. So this happens atomically even without the lock. Isn= 't >> it? Am I missing something here? I don't see any contention for the thre= ad >> in order to demand a lock for the thread which will basically protect th= e >> contents of the thread structure for the thread. >> >> Dheeraj >> >> > The thread lock also happens to protect various scheduler variables: > > struct mtx *volatile td_lock; /* replaces sched lock */ > > see sys/kern/sched_ule.c on how the thread lock td_lock is changed > depending on what the thread is doing. > > -- > Alfred Perlstein > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BqNgxS7RHj2LpdyADhgyjSDYfZDJODgyjV4m1yT6o5DchHQ-w>