Date: Sat, 2 Aug 2014 00:05:37 +0200 From: Svatopluk Kraus <onwahe@gmail.com> To: freebsd-current@freebsd.org Cc: jmg@funkthat.com Subject: Re: domain_add(xxx) after domainfinalize... Message-ID: <CAFHCsPXPZ3M2xk=P4XJvDx-NGZ0_GS573Ay2%2BMmnb21w3N%2B3UQ@mail.gmail.com> In-Reply-To: <20140801193403.GE50495@funkthat.com> References: <20140801193403.GE50495@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Just what I've got in January 2011: http://lists.freebsd.org/pipermail/freebsd-hackers/2011-January/034037.html Svata On Fri, Aug 1, 2014 at 9:34 PM, John-Mark Gurney <jmg@funkthat.com> wrote: > So, I have a laptop that devd loads the bluetooth module every time.. > > This means I get the following error on every boot: > WARNING: attempt to domain_add(bluetooth) after domainfinalize() > WARNING: attempt to domain_add(netgraph) after domainfinalize() > > Is there any real benefit to this warning? I just looked at the code, > and the domain gets added despite the warning... > > Also, it looks like the pervious warning, we should just make that an > if/panic since it's clearly a programming bug, or kill the ifndef > INVARIANTS... > > Index: uipc_domain.c > =================================================================== > --- uipc_domain.c (revision 266964) > +++ uipc_domain.c (working copy) > @@ -227,15 +227,6 @@ > printf("WARNING: attempt to domain_add(%s) before " > "domaininit()\n", dp->dom_name); > #endif > -#ifdef notyet > - KASSERT(domain_init_status < 2, > - ("attempt to domain_add(%s) after domainfinalize()", > - dp->dom_name)); > -#else > - if (domain_init_status >= 2) > - printf("WARNING: attempt to domain_add(%s) after " > - "domainfinalize()\n", dp->dom_name); > -#endif > mtx_unlock(&dom_mtx); > } > > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not." > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFHCsPXPZ3M2xk=P4XJvDx-NGZ0_GS573Ay2%2BMmnb21w3N%2B3UQ>