Date: Wed, 28 Jan 2015 08:42:48 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Alexander Kabaev <kabaev@gmail.com> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, svn-src-projects@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r277803 - projects/clang360-import/lib/clang/include Message-ID: <F7477A20-BC56-4CF9-8520-77F7BFD4B72E@FreeBSD.org> In-Reply-To: <20150127191134.4fe3a17f@kan> References: <201501271925.t0RJPem3010417@svn.freebsd.org> <CAJ5_RoAvww7xFsSTBMPDThYsbpVbxOs11nWE=eEXpJRFx_kyww@mail.gmail.com> <20150127191134.4fe3a17f@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D524E557-6971-4AC2-9A6E-7902AC765974 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 28 Jan 2015, at 01:11, Alexander Kabaev <kabaev@gmail.com> wrote: On Tue, 27 Jan 2015 14:34:21 -0500 > > Benjamin Kaduk <bjkfbsd@gmail.com> wrote: > >> On Tue, Jan 27, 2015 at 2:25 PM, Dimitry Andric <dim@freebsd.org> >> wrote: >> >>> Author: dim >>> Date: Tue Jan 27 19:25:39 2015 >>> New Revision: 277803 >>> URL: https://svnweb.freebsd.org/changeset/base/277803 >>> >>> Log: >>> Change the path to clang's private headers. Upstream has always >>> stored these in $LIBDIR/clang/$VERSION/include, instead of our >>> previous custom location in /usr/include/clang/$VERSION. This >>> allows us to drop yet another FreeBSD-specific patch. >>> >>> Modified: >>> projects/clang360-import/lib/clang/include/Makefile >>> >>> Modified: projects/clang360-import/lib/clang/include/Makefile >>> > > I think spreading .h files all over the tree is actually a regression. I'm not sure what the problem is with storing a compiler's internal-only headers in the location where upstream expects them to be? Note that gcc does something similar; for example with the gcc49 port, it stores all its internal headers under: /usr/local/lib/gcc49/gcc/i386-portbld-freebsd11.0/4.9.3/include While I do agree that this is not a pretty-looking path, upstream has chosen it to be like this, and there are most likely good reasons for it. As for clang, I just want to get rid of as many "FreeBSD is a special snowflake" patches as I can. -Dimitry --Apple-Mail=_D524E557-6971-4AC2-9A6E-7902AC765974 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTIkwEACgkQsF6jCi4glqNVqwCdGeD8q9V3cuZQvam856JsQMPp pt4AoN435R9/B/brEMTxB/2bnDDexPnM =3jzI -----END PGP SIGNATURE----- --Apple-Mail=_D524E557-6971-4AC2-9A6E-7902AC765974--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F7477A20-BC56-4CF9-8520-77F7BFD4B72E>