Date: Thu, 11 Jan 2001 11:52:46 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: Bruce Evans <bde@zeta.org.au>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder <jake@FreeBSD.org>, =?ISO-8859-1?Q?G=E9rard_Roudier?= <groudier@club-internet.fr> Subject: Re: cvs commit: src/sys/alpha/alpha interrupt.c machdep.c mp_mac Message-ID: <XFMail.010111115246.jhb@FreeBSD.org> In-Reply-To: <200101111912.f0BJCfs36487@aslan.scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11-Jan-01 Justin T. Gibbs wrote: >>These variables are magic. A developer can find out that they are magic in >>on >>e >>of two ways: >> >>1) Use a special macro that acknowledges that they are magic, and have the >>compile break if they don't so that they know there is something they need to >>take into account. >> >>2) Go memorize all aforementioned headers to know that these variables are >>magic. > > There is no reason that for two to be the case. We are only talking > about a naming difference. Having the headers cleaned up is a different > argument. > >>I prefer the interface 1) for this. Do you prefer 2)? > > I prefer "curproc" to PCPU_GET(curproc). Curproc already tells me > that this variable must be per-cpu. How? And does witness_spin_check tell you this, or astpending? astpending wasn't even per-CPU before the first SMPng commit. How about common_tss? > -- > Justin -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010111115246.jhb>