Date: Sun, 16 Nov 2025 11:26:55 +0000 From: Rene Ladan <rene@freebsd.org> To: Max Brazhnikov <makc@freebsd.org> Cc: Nuno Teixeira <eduardo@freebsd.org>, ports-committers@freebsd.org, =?iso-8859-1?Q?Jes=FAs?= Daniel Colmenares Oviedo <dtxdf@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, DtxdF@disroot.org, portmgr@freebsd.org Subject: Re: Literal text WWW in ports Makefile (Was: git: 4bb2e36e912e - main - sysutils/gol: New port: All-in-one log viewer in browser) Message-ID: <aRm0_7XrbKBT7JFc@freefall.freebsd.org> In-Reply-To: <1806919.NDq42KOioK@mercury> References: <202511150000.5AF00UV0020031@gitrepo.freebsd.org> <CAFDf7ULmQyKHKjVf%2BAiaQZ6XCcuNRKg3XMHThUgUm=TyBbmq%2BQ@mail.gmail.com> <fb45785afd24d80aa1e2bf53ac38e099@disroot.org> <1806919.NDq42KOioK@mercury>
index | next in thread | previous in thread | raw e-mail
On Sat, Nov 15, 2025 at 09:16:30PM +0300, Max Brazhnikov wrote: > On Sat, 15 Nov 2025 12:55:03 -0400 DtxdF@disroot.org wrote: > > > Can we avoid variables in WWW for easier reading when taking a look at > > > Makefiles? I remember that this subject was discussed some time ago... > > > > From rene@, when we talked about this a while ago: > > > > > Well, WWW is variable parsed by make, not by humans, so referencing > > The whole Makefile is parsed by the make, however we do have style rules to > ease reading Makefiles by contributes and committers. > > > > PORTNAME is legal here. It *was* a literal text back when it was > > > part of pkg-descr. > > WWW also was a literal text when it just migrated to Makefile. Why it should > be obfuscated now? No difference for the make, but less convenient for humans: > plain text url can be opened from the editor without running the make. > > I propose to supplement Porter's Handbook with a recommendation to avoid > variables in WWW when it is explicitly set in the Makefile. > > Shall we put it to the vote? :) > WWW is a variable, just like any other variable in Makefile, and Makefile is a machine-readable file, unlike e.g. pkg-descr. You cannot humanly read the value of MASTER_SITES either. The Porters Handbook likely predates the move of WWW from pkg-descr to Makefile. Kind regards, Renéhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aRm0_7XrbKBT7JFc>