Date: Fri, 01 Mar 2024 21:20:51 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Gleb Popov <arrowd@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: c2afef5c2587 - main - Features/testing.mk: Introduce the TESTING_UNSAFE knob. Message-ID: <ab6429b3b2004cd8ad9e7ed0b563a5c9@mail.infomaniak.com> In-Reply-To: <202403011927.421JRqxx065749@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-03-01T20:27:52.000+01:00, Gleb Popov <arrowd@FreeBSD.org> wrote: > The branch main has been updated by arrowd: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=c2afef5c2587738b16b52def34edcebe4e421905 > > commit c2afef5c2587738b16b52def34edcebe4e421905 > > Author: Gleb Popov <arrowd@FreeBSD.org> > > AuthorDate: 2024-03-01 19:25:37 +0000 > > Commit: Gleb Popov <arrowd@FreeBSD.org> > > CommitDate: 2024-03-01 19:26:53 +0000 > > Features/testing.mk [http://testing.mk]: Introduce the TESTING_UNSAFE knob. > > > > Approved by: tcberner > > --- > > Mk/Features/testing.mk [http://testing.mk] | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Mk/Features/testing.mk [http://testing.mk] b/Mk/Features/testing.mk [http://testing.mk] > > index 15af7e28eb7c..a266f6effe91 100644 > > --- a/Mk/Features/testing.mk [http://testing.mk] > > +++ b/Mk/Features/testing.mk [http://testing.mk] > > @@ -4,12 +4,15 @@ > > # - If set, and the port supports it, the software's test suite will be compiled > > # and run during the normal building pipeline between 'stage' and 'package' > > # stages. > > +# - A port may define TESTING_UNSAFE=yes if its tests are known to fail at the > > +# moment. > > > > .if !defined(_TESTING_MK_INCLUDED) > > _TESTING_MK_INCLUDED= yes > > TESTING_Include_MAINTAINER= portmgr@FreeBSD.org > > > > +. if !defined(TESTING_UNSAFE) > > _TESTING_PACKAGE_DEP= test > > +. endif > > > > .endif > > - Hi, Thanks for adding this, however this won't work on ports that uses TEST menu option as far as I can tell which is a relatively common occurence? Se also https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495 Best regards, Daniel [-- Attachment #2 --] <div>On 2024-03-01T20:27:52.000+01:00, Gleb Popov <arrowd@FreeBSD.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by arrowd:<br></div><div><br></div><div>URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=c2afef5c2587738b16b52def34edcebe4e421905" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=c2afef5c2587738b16b52def34edcebe4e421905</a><br></div><div><br></div><div>commit c2afef5c2587738b16b52def34edcebe4e421905<br></div><div>Author: Gleb Popov <<a class="defaultMailLink" href="mailto:arrowd@FreeBSD.org">arrowd@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-03-01 19:25:37 +0000<br></div><div>Commit: Gleb Popov <<a class="defaultMailLink" href="mailto:arrowd@FreeBSD.org">arrowd@FreeBSD.org</a>><br></div><div>CommitDate: 2024-03-01 19:26:53 +0000<br></div><div><br></div><div> Features/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://testing.mk" target="_blank">testing.mk</a>: Introduce the TESTING_UNSAFE knob.<br></div><div> <br></div><div> Approved by: tcberner<br></div><div>---<br></div><div> Mk/Features/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://testing.mk" target="_blank">testing.mk</a> | 5 ++++-<br></div><div> 1 file changed, 4 insertions(+), 1 deletion(-)<br></div><div><br></div><div>diff --git a/Mk/Features/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://testing.mk" target="_blank">testing.mk</a> b/Mk/Features/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://testing.mk" target="_blank">testing.mk</a><br></div><div>index 15af7e28eb7c..a266f6effe91 100644<br></div><div>--- a/Mk/Features/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://testing.mk" target="_blank">testing.mk</a><br></div><div>+++ b/Mk/Features/<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://testing.mk" target="_blank">testing.mk</a><br></div><div>@@ -4,12 +4,15 @@<br></div><div> # - If set, and the port supports it, the software's test suite will be compiled<br></div><div> # and run during the normal building pipeline between 'stage' and 'package'<br></div><div> # stages.<br></div><div>+# - A port may define TESTING_UNSAFE=yes if its tests are known to fail at the<br></div><div>+# moment.<br></div><div> <br></div><div> .if !defined(_TESTING_MK_INCLUDED)<br></div><div> _TESTING_MK_INCLUDED= yes<br></div><div> TESTING_Include_MAINTAINER= <a class="defaultMailLink" href="mailto:portmgr@FreeBSD.org">portmgr@FreeBSD.org</a><br></div><div> <br></div><div>+. if !defined(TESTING_UNSAFE)<br></div><div> _TESTING_PACKAGE_DEP= test<br></div><div>+. endif<br></div><div> <br></div><div> .endif<br></div><div>-<br></div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>Thanks for adding this, however this won't work on ports that uses TEST menu option as far as I can tell which is a relatively common occurence?<br></div><div><br></div><div>Se also <a href="https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495</a><br></div><div>Best regards,<br></div><div>Daniel<br></div><div ><div><br></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ab6429b3b2004cd8ad9e7ed0b563a5c9>