Date: Thu, 22 Apr 2010 16:19:25 +0200 (CEST) From: =?ISO-8859-1?Q?Trond_Endrest=F8l?= <Trond.Endrestol@fagskolen.gjovik.no> To: Eitan Adler <eitanadlerlist@gmail.com> Cc: freebsd-hackers@freebsd.org, Ruben de Groot <mail25@bzerk.org>, Doug Barton <dougb@freebsd.org>, "Aryeh M. Friedman" <aryeh.friedman@gmail.com> Subject: Re: regenerating /var/db/pkg Message-ID: <alpine.BSF.2.00.1004221610520.29574@mail.fig.ol.no> In-Reply-To: <o2oa0777e081004220521sae3b1b06o884fd8eadffc6931@mail.gmail.com> References: <4BCE5ECC.6070202@gmail.com> <4BCFE209.20501@FreeBSD.org> <20100422111758.GA39338@ei.bzerk.org> <o2oa0777e081004220521sae3b1b06o884fd8eadffc6931@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2055831798-1592387152-1271945970=:29574 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, 22 Apr 2010 15:21+0300, Eitan Adler wrote: > > Just asking opinions, if people want this, I'll make a patch and > > file a PR. > > Is this script correct? > > #!/bin/sh > # > # $FreeBSD: src/etc/periodic/daily/210.backup-aliases,v 1.6.36.1.2.1 2009/10/25 01:10:29 kensmith Exp $ > # > > # If there is a global system configuration file, suck it in. > # > if [ -r /etc/defaults/periodic.conf ] > then > . /etc/defaults/periodic.conf > source_periodic_confs > fi > > bak=/var/backups > db_loc="/var/db/pkg"; > bk_loc="/$bak/pkgdb.bak.tar" It's really no big deal, but from a pragmatic view I'd write: bk_loc="$bak/pkgdb.bak.tar" Otherwise $bk_loc will contain: //var/backups/pkgdb.bak.tar > > case "$daily_backup_pkgdb_enable" in > [Yy][Ee][Ss]) > if [ ! -d $db_loc ] > then > echo '$daily_backup_pkgdb_enable is enabled but' \ > "$db_loc doesn't exist" > rc=2 > else > rc=0 > > echo "" > echo "Backing up mail aliases:" It's really the package directory, no? > if [ ! -f $bk_loc ] > then > echo "no $bk_loc" > tar -cjf $bk_loc $db_loc || rc=3 How do you plan to capture changes made to /var/db/pkg? If we're supposed to manually delete /var/backups/pkgdb.bak.tar from time to time, then the presented code is probably ok. > fi > fi;; > > *) rc=0;; > esac > > exit $rc Just my $0.02, Trond. - -- - ---------------------------------------------------------------------- Trond Endrestøl | Trond.Endrestol@fagskolen.gjovik.no ACM, NAS, NUUG, SAGE, USENIX | FreeBSD 8.0-STABLE & Alpine 2.00 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkvQWvIACgkQbYWZalUoEluyegCfYq/FMpdT9/wRGQyGF8+2WgKQ aGIAn2S2br054BRHc38IpB4uWYVYH94I =GA9V -----END PGP SIGNATURE----- --2055831798-1592387152-1271945970=:29574--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1004221610520.29574>