Date: Fri, 14 May 2010 22:12:19 -0400 (EDT) From: Benjamin Kaduk <kaduk@MIT.EDU> To: Alan Cox <alc@cs.rice.edu> Cc: Kostik Belousov <kostikbel@gmail.com>, alc@freebsd.org, freebsd-current@freebsd.org Subject: Re: kgdb unuseable with cores on current (for some people) Message-ID: <alpine.GSO.1.10.1005142210080.29136@multics.mit.edu> In-Reply-To: <alpine.GSO.1.10.1005141346170.29136@multics.mit.edu> References: <alpine.GSO.1.10.1005140013260.29136@multics.mit.edu> <20100514053907.GL83316@deviant.kiev.zoral.com.ua> <alpine.GSO.1.10.1005140243030.29136@multics.mit.edu> <4BED8ADE.1030100@cs.rice.edu> <alpine.GSO.1.10.1005141346170.29136@multics.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 14 May 2010, Benjamin Kaduk wrote:
> On Fri, 14 May 2010, Alan Cox wrote:
>
>>
>> I suspect the following is needed:
>>
>> Index: vm/vm_page.c
>> ===================================================================
>> --- vm/vm_page.c (revision 207823)
>> +++ vm/vm_page.c (working copy)
>> @@ -108,6 +108,7 @@ __FBSDID("$FreeBSD$");
>> #include <sys/kernel.h>
>> #include <sys/limits.h>
>> #include <sys/malloc.h>
>> +#include <sys/msgbuf.h>
>> #include <sys/mutex.h>
>> #include <sys/proc.h>
>> #include <sys/sysctl.h>
>> @@ -375,6 +376,14 @@ vm_page_startup(vm_offset_t vaddr)
>> new_end + vm_page_dump_size, VM_PROT_READ | VM_PROT_WRITE);
>> bzero((void *)vm_page_dump, vm_page_dump_size);
>> #endif
>> +#ifdef __amd64__
>> + pa = DMAP_TO_PHYS((vm_offset_t)msgbufp);
If I change this to be msgbufp->msg_ptr, then all works as expected.
While tracking this down, I realized that passing the -q(uiet) argument to
kgdb would have been a valid workaround all along.
Alan, could you please commit the modified patch?
Thanks,
Ben Kaduk
>> + last_pa = pa + round_page(MSGBUF_SIZE);
>> + while (pa < last_pa) {
>> + dump_add_page(pa);
>> + pa += PAGE_SIZE;
>> + }
>> +#endif
>> /*
>> * Compute the number of pages of memory that will be available for
>> * use (taking into account the overhead of a page structure per
>>
>>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.GSO.1.10.1005142210080.29136>