Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Dec 2023 13:23:02 -0800
From:      Craig Leres <leres@freebsd.org>
To:        Konstantin Belousov <kostikbel@gmail.com>, d@delphij.net
Cc:        freebsd-current@freebsd.org
Subject:   Re: Proposal: Disable compression of newsyslog by default
Message-ID:  <b0c6b054-090e-45f5-a1e0-ddc40efcc27f@freebsd.org>
In-Reply-To: <ZYb0P4XSCxhoNHmo@kib.kiev.ua>
References:  <ace7d170-acd1-4dc8-8016-a08c261d91f0@delphij.net> <ZYb0P4XSCxhoNHmo@kib.kiev.ua>

index | next in thread | previous in thread | raw e-mail

On 12/23/23 06:52, Konstantin Belousov wrote:
> This is strange change at best.  I have no opinion about the disabling
> of compression of the rotated logs by default, but we already have knobs
> to do that.  Adding a knob that disables (or enables) other knobs to work
> is weird.

I totally agree. This moves the compression knob from the config file to 
the command line. And what if the user wants some but not all files to 
be compressed? Or wants to use different compression with different log 
files?

> If you want to change the compression, update the default configuration file.

I also think this is the best approach.

Given the current freebsd-update workflow, users will get to deal with 
changes to the default newsyslog.conf via mergemaster.

And having converted a number of systems from newsyslog compression to 
zfs compression, just changing the config file is not the only change 
needed, users will still need to compress/uncompress existing log files.

		Craig


help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b0c6b054-090e-45f5-a1e0-ddc40efcc27f>