Date: Tue, 18 Mar 2008 08:24:16 -0800 From: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com> To: "Iain Hibbert" <plunky@rya-online.net> Cc: freebsd-bluetooth@freebsd.org Subject: Re: Bluetooth PAN support for FreeBSD Message-ID: <bb4a86c70803180924k5e5c2bdejd8ee4a2e06da9da9@mail.gmail.com> In-Reply-To: <1205833527.826584.1207.nullmailer@galant.ukfsn.org> References: <47D5BEE3.80109@gmail.com> <bb4a86c70803101643yf15fd84p2184adfd8a452348@mail.gmail.com> <bb4a86c70803171735j2f6b6ef3pc340c51a9296e038@mail.gmail.com> <1205833527.826584.1207.nullmailer@galant.ukfsn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/18/08, Iain Hibbert <plunky@rya-online.net> wrote:
> On Mon, 17 Mar 2008, Maksim Yevmenkin wrote:
>
> > i have committed support for bnep based profiles into -current and
> > have mfc'd it into releng_7 and _6.
>
>
> +struct sdp_nap_profile
> +{
> + uint16_t security_description; /* HBO: NAP/GN */
> + uint16_t net_access_type; /* HBO: NAP */
> + uint32_t max_net_access_rate; /* HBO: NAP */
> +};
>
> what does HBO mean?
host byte order.
> also, why no PSM and load_factor ?
>
> uint16_t psm;
> uint8_t load_factor;
>
> both would seem useful here..
well, psm comes from assigned numbers specification, i.e. 15. my
initial concern was about "broken" devices, i.e. devices that do not
make sdp query and simply use default psm. however, this is a bogus
argument because if device does not use sdp it really does not matter
what i put in there :) so, i really do not have very strong opinion
about it. it is trivial to add if people want it.
i did not add load_factor because i was not sure if anybody ever going
to look at it. it is marked as optional. again, it is trivial to add
if people want it.
thanks,
max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70803180924k5e5c2bdejd8ee4a2e06da9da9>