Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 19 May 2016 10:49:56 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-arm@FreeBSD.org
Subject:   [Bug 209635] usr/src/sys/arm/xscale/ixp425/ixp425_npe.c:695: pointless test ?
Message-ID:  <bug-209635-7@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail 

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209635

            Bug ID: 209635
           Summary: usr/src/sys/arm/xscale/ixp425/ixp425_npe.c:695:
                    pointless test ?
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: arm
          Assignee: freebsd-arm@FreeBSD.org
          Reporter: dcb314@hotmail.com

usr/src/sys/arm/xscale/ixp425/ixp425_npe.c:695]: (style) Unsigned variable
'cNum' can't be negative so it is unnecessary to test it.

Source code is

       if (!(0 <= cNum && cNum < IX_NPEDL_CTXT_NUM_MAX)) {

but

       uint32_t cNum = (addrInfo & IX_NPEDL_MASK_STATE_ADDR_CTXT_NUM) >>
            IX_NPEDL_OFFSET_STATE_ADDR_CTXT_NUM;

-- 
You are receiving this mail because:
You are the assignee for the bug.
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209635-7>