Date: Fri, 23 Feb 2024 21:12:53 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 277269] [nanoBSD] setting NANO_PMAKE in defaults.sh renders setting NANO_NCPU in config useless Message-ID: <bug-277269-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277269 Bug ID: 277269 Summary: [nanoBSD] setting NANO_PMAKE in defaults.sh renders setting NANO_NCPU in config useless Product: Base System Version: 14.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: misc Assignee: bugs@FreeBSD.org Reporter: embhd@posteo.de Created attachment 248702 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=248702&action=edit Patch As of now, the default value of the variable NANO_PMAKE ("Parallel MAKE") as set in the script `default.sh` contains the default value of NANO_NCPU ("Number of CPUs used"). Thus, if NANO_NCPU is set to a different value in the respective config file, this won't change anything for the actual build, since the value of NANO_PMAKE is not automatically updated to the configured number of cores - rendering the variable more or less useless. The proposed solution (c.f. the patch attached) is to eliminate the variable NANO_PMAKE and use the "original" variables NANO_MAKE and NANO_NCPU directly, since it only affects two places in `defaults.sh´. In addition, the patch adds the missing available options to the output of `nanobsd.sh -h`. -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-277269-227>