Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 07 Jul 2025 15:07:33 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 288077] ixl driver does not properly reenable interrupts for msi.
Message-ID:  <bug-288077-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288077

            Bug ID: 288077
           Summary: ixl driver does not properly reenable interrupts for
                    msi.
           Product: Base System
           Version: 13.5-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: mibelanger@qnx.com

If msix is disabled or unavailable, msi interrupts are not properly reenabled.

The issue is in ixl_if_enable_intr.  It is not consistent with what is being
done in ixl_if_disable_intr.

Changing the following:

        ixl_enable_intr0(hw);
        /* Enable queue interrupts */
        for (int i = 0; i < vsi->num_rx_queues; i++, que++)
                /* TODO: Queue index parameter is probably wrong */
                ixl_enable_queue(hw, que->rxr.me);

to:
        if (vsi->shared->isc_intr == IFLIB_INTR_MSIX) {
                ixl_enable_intr0(hw);
                /* Enable queue interrupts */
                for (int i = 0; i < vsi->num_rx_queues; i++, que++)
                        /* TODO: Queue index parameter is probably wrong */
                        ixl_enable_queue(hw, que->rxr.me);
        } else {
                /*
                 * Set PFINT_LNKLST0 FIRSTQ_INDX to 0x00
                 * starts queues - allows interrupts
                 */
                wr32(hw, I40E_PFINT_LNKLST0, 0x0);
        }

will resolve the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-288077-227>