Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Feb 2026 19:06:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 292916] Multiple valid gcc compiler warnings when building kerberos5/lib/libhdb after :main@5000d023a446
Message-ID:  <bug-292916-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292916

            Bug ID: 292916
           Summary: Multiple valid gcc compiler warnings when building
                    kerberos5/lib/libhdb after :main@5000d023a446
           Product: Base System
           Version: 14.3-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: bugs@FreeBSD.org
          Reporter: ngie@FreeBSD.org

From
https://ci.freebsd.org/job/FreeBSD-stable-14-amd64-gcc14_build/895/consoleText
:

```
--- hdb-mitdb.o ---
/workspace/src/crypto/heimdal/lib/hdb/hdb-mitdb.c:780:11: error: implicit
declaration of function '_hdb_set_master_key_usage'; did you mean
'hdb_set_master_keyfile'? [-Wimplicit-function-declaration]
  780 |     ret = _hdb_set_master_key_usage(context, db, 0); /* MIT KDB uses KU
0 */
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~
      |           hdb_set_master_keyfile
--- ndbm.o ---
/usr/local/bin/x86_64-unknown-freebsd14.3-gcc14
--sysroot=/tmp/obj/workspace/src/amd64.amd64/tmp
-B/usr/local/x86_64-unknown-freebsd14.3/bin/  -O2 -pipe -fno-common
-I/workspace/src/crypto/heimdal/lib/hdb
-I/workspace/src/crypto/heimdal/lib/asn1 
-I/workspace/src/crypto/heimdal/lib/roken -I/workspace/src/contrib/sqlite3/ 
-I/workspace/src/crypto/heimdal/lib/krb5  -I/workspace/src/contrib/com_err  -I.
 -DHDB_DB_DIR="\"/var/heimdal\""   -DHAVE_CONFIG_H
-I/workspace/src/kerberos5/include -ffile-prefix-map=/workspace/src=/usr/src
-ffile-prefix-map=/tmp/obj/workspace/src=/usr/obj -g -MD  -MF.depend.ndbm.o
-MTndbm.o -std=gnu99 -Wno-format-zero-length -fstack-protector-strong
-Wno-pointer-sign -Wdate-time -Wno-error=address -Wno-error=array-bounds
-Wno-error=attributes -Wno-error=bool-compare -Wno-error=cast-align
-Wno-error=clobbered -Wno-error=deprecated-declarations -Wno-error=enum-compare
-Wno-error=extra -Wno-error=logical-not-parentheses -Wno-error=strict-aliasing
-Wno-error=uninitialized -Wno-error=unused-function -Wno-error=unused-value
-Wno-error=empty-body -Wno-error=maybe-uninitialized -Wno-error=nonnull-compare
-Wno-error=shift-negative-value -Wno-error=tautological-compare
-Wno-error=unused-const-variable -Wno-error=bool-operation
-Wno-error=deprecated -Wno-error=expansion-to-defined
-Wno-error=format-overflow -Wno-error=format-truncation
-Wno-error=implicit-fallthrough -Wno-error=int-in-bool-context
-Wno-error=memset-elt-size -Wno-error=noexcept-type -Wno-error=nonnull
-Wno-error=pointer-compare -Wno-error=stringop-overflow
-Wno-error=aggressive-loop-optimizations -Wno-error=cast-function-type
-Wno-error=catch-value -Wno-error=multistatement-macros -Wno-error=restrict
-Wno-error=sizeof-pointer-memaccess -Wno-error=stringop-truncation
-Wno-return-type -Wno-address-of-packed-member      -c
/workspace/src/crypto/heimdal/lib/hdb/ndbm.c -o ndbm.o
--- secure/lib/libssh__L ---
--- canohost.o ---
/usr/local/bin/x86_64-unknown-freebsd14.3-gcc14
--sysroot=/tmp/obj/workspace/src/amd64.amd64/tmp
-B/usr/local/x86_64-unknown-freebsd14.3/bin/  -O2 -pipe -fno-common  
-I/workspace/src/crypto/openssh -include ssh_namespace.h -include krb5_config.h
-DXAUTH_PATH=\"/usr/local/bin/xauth\" -DHAVE_LDNS=1 -DLIBWRAP=1 -include
sk_config.h -DOPENSSL_API_COMPAT=0x10100000L -I/workspace/src/contrib/ldns
-ffile-prefix-map=/workspace/src=/usr/src
-ffile-prefix-map=/tmp/obj/workspace/src=/usr/obj -g -MD  -MF.depend.canohost.o
-MTcanohost.o -std=gnu99 -Wno-format-zero-length -fstack-protector-strong
-Wno-pointer-sign -Wdate-time -Wno-error=address -Wno-error=array-bounds
-Wno-error=attributes -Wno-error=bool-compare -Wno-error=cast-align
-Wno-error=clobbered -Wno-error=deprecated-declarations -Wno-error=enum-compare
-Wno-error=extra -Wno-error=logical-not-parentheses -Wno-error=strict-aliasing
-Wno-error=uninitialized -Wno-error=unused-function -Wno-error=unused-value
-Wno-error=empty-body -Wno-error=maybe-uninitialized -Wno-error=nonnull-compare
-Wno-error=shift-negative-value -Wno-error=tautological-compare
-Wno-error=unused-const-variable -Wno-error=bool-operation
-Wno-error=deprecated -Wno-error=expansion-to-defined
-Wno-error=format-overflow -Wno-error=format-truncation
-Wno-error=implicit-fallthrough -Wno-error=int-in-bool-context
-Wno-error=memset-elt-size -Wno-error=noexcept-type -Wno-error=nonnull
-Wno-error=pointer-compare -Wno-error=stringop-overflow
-Wno-error=aggressive-loop-optimizations -Wno-error=cast-function-type
-Wno-error=catch-value -Wno-error=multistatement-macros -Wno-error=restrict
-Wno-error=sizeof-pointer-memaccess -Wno-error=stringop-truncation
-Wno-return-type -Wno-address-of-packed-member      -c
/workspace/src/crypto/openssh/canohost.c -o canohost.o
--- kerberos5/lib/libhdb__L ---
--- hdb-mitdb.o ---
/workspace/src/crypto/heimdal/lib/hdb/hdb-mitdb.c:794:11: error: implicit
declaration of function '_hdb_mit_dump2mitdb_entry'
[-Wimplicit-function-declaration]
  794 |     ret = _hdb_mit_dump2mitdb_entry(context, line.data, spent);
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~
*** [hdb-mitdb.o] Error code 1

make[4]: stopped in /workspace/src/kerberos5/lib/libhdb
--- secure/lib/libssh__L ---

make[3]: stopped in /workspace/src
--- kerberos5/lib/libhdb__L ---
--- keys.o ---
/workspace/src/crypto/heimdal/lib/hdb/keys.c: In function
'hdb_add_current_keys_to_history':
/workspace/src/crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on
pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object]
  241 |             free(hist_keys);
      |             ^~~~~~~~~~~~~~~
/workspace/src/crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from
'calloc'
  234 |         ext = calloc(1, sizeof (*ext));
      |               ^~~~~~~~~~~~~~~~~~~~~~~~
--- kerberos5/lib/libheimntlm__L ---

make[3]: stopped in /workspace/src
--- kerberos5/lib/libhdb__L ---
1 error

make[4]: stopped in /workspace/src/kerberos5/lib/libhdb

make[3]: stopped in /workspace/src

make[2]: stopped in /workspace/src
      307.53 real      3191.12 user       292.81 sys

make[1]: stopped in /workspace/src

make: stopped in /workspace/src
```

The `_hdb_mit_dump2mitdb_entry` not being declared issue is the highest
priority item, but the other items matter as well.

This is fallout from this commit:
```
commit a93e1b731ae440ac3471792c52db8fb07b93d265
Author: Rick Macklem <rmacklem@FreeBSD.org>
Date:   Sun Oct 5 09:18:35 2025 -0700

    heimdal-kadmin: Add support for the -f dump option

    The "-f" dump option allows a dump of the Heimdal
    KDC in a format that the MIT kdb5_util command can
    load into a MIT KDC's database.
    This makes transitioning from the Heimdal KDC to
    the current MIT one feasible without having to
    re-create the KDC database from scratch.

    glebius@ did the initial work, cherry picking these
    commits from the Heimdal sources on github and then doing
    extensive merge conflict resolution and other fixes so
    that it would build.
    Heimdal commit fca5399 authored by Nico Williams:
    Initial commit for second approach for multiple kvno.  NOT TESTED!

    Heimdal commit 57f1545 authored by Nico Williams:
    Add support for writing to KDB and dumping HDB to MIT KDB dump format
        Before this change Heimdal could read KDBs.  Now it can write to
        them too.

        Heimdal can now also dump HDBs (including KDBs) in MIT format,
        which can then be imported with kdb5_util load.

        This is intended to help in migrations from MIT to Heimdal by
        allowing migrations from Heimdal to MIT so that it is possible
        to rollback from Heimdal to MIT should there be any issues.  The
        idea is to allow a) running Heimdal kdc/kadmind with a KDB, or
        b) running Heimdal with an HDB converted from a KDB and then
        rollback by dumping the HDB and loading a KDB.

        Note that not all TL data types are supported, only two: last
        password change and modify-by.  This is the minimum necessary.
        PKINIT users may need to add support for KRB5_TL_USER_CERTIFICATE,
        and for databases with K/M history we may need to add KRB5_TL_MKVNO
        support.

...
```

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-292916-227>