Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Jan 2017 18:55:18 +0200
From:      Andriy Gapon <avg@FreeBSD.org>
To:        freebsd-geom@FreeBSD.org
Subject:   g_disk_done() vs a destroyed disk
Message-ID:  <cba9c9bf-97ad-e3ae-e209-ea91e49b5822@FreeBSD.org>

next in thread | raw e-mail | index | archive | help

I've seen a situation where g_disk_done() was called on a bio after the
corresponding disk had been already destroyed via g_disk_destroy().
That call resulted in a crash here:
	devstat_end_transaction_bio_bt(sc->dp->d_devstat, bp, &now);
because sc->dp was NULL.

Is it a bug that we do not check for dp being NULL (or dp->d_destroyed being
set) in g_disk_done() ?
Or is it a bug that a controller driver called biodone() for that bio having
earlier called disk_destroy() ?

Thanks!
-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cba9c9bf-97ad-e3ae-e209-ea91e49b5822>