Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Jul 2015 19:01:37 +0000
From:      "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org>
To:        freebsd-toolchain@freebsd.org
Subject:   [Differential] [Request, 2 lines] D3190: ar: enable deterministic mode by default
Message-ID:  <differential-rev-PHID-DREV-usn5i3qzb3c4qoqpymts-req@FreeBSD.org>

index | next in thread | raw e-mail

[-- Attachment #1 --]
emaste created this revision.
emaste added reviewers: bapt, brooks.
emaste added a subscriber: freebsd-toolchain-list.

REVISION SUMMARY
  Ar cannot handle UIDs with more than 6 digits, and there's little value in storing the mtime, uid, gid and mode anyhow.  Turn on deterministic (-D) mode by default; it can be disabled by the user with -U.
  
  PR:         196929
  Relnotes:   Yes
  Sponsored by:       The FreeBSD Foundation

REVISION DETAIL
  https://reviews.freebsd.org/D3190

AFFECTED FILES
  usr.bin/ar/ar.c

CHANGE DETAILS
  diff --git a/usr.bin/ar/ar.c b/usr.bin/ar/ar.c
  --- a/usr.bin/ar/ar.c
  +++ b/usr.bin/ar/ar.c
  @@ -104,6 +104,8 @@
   
   	bsdar = &bsdar_storage;
   	memset(bsdar, 0, sizeof(*bsdar));
  +	/* Enable deterministic mode by default. */
  +	bsdar->options |= AR_D;
   
   	if ((bsdar->progname = getprogname()) == NULL)
   		bsdar->progname = "ar";

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: emaste, bapt, brooks
Cc: freebsd-toolchain-list

[-- Attachment #2 --]
diff --git a/usr.bin/ar/ar.c b/usr.bin/ar/ar.c
--- a/usr.bin/ar/ar.c
+++ b/usr.bin/ar/ar.c
@@ -104,6 +104,8 @@
 
 	bsdar = &bsdar_storage;
 	memset(bsdar, 0, sizeof(*bsdar));
+	/* Enable deterministic mode by default. */
+	bsdar->options |= AR_D;
 
 	if ((bsdar->progname = getprogname()) == NULL)
 		bsdar->progname = "ar";

help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?differential-rev-PHID-DREV-usn5i3qzb3c4qoqpymts-req>