Date: Fri, 09 Feb 2024 02:47:52 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Moin Rahman <bofh@freebsd.org> Cc: Chris <i.h8.git@BSDforge.com>, Daniel Engberg <diizzy@freebsd.org>, ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e2b4eb57621f - main - graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29 Message-ID: <efdf6e20044a5e482e36ea7dfe7ca965@mail.infomaniak.com> In-Reply-To: <A3FF2AF8-CAD9-4D0D-AFDE-3E1FCABD613E@freebsd.org> References: <202402082211.418MBK2t091444@gitrepo.freebsd.org> <9b6a0d96cb2fe54d6702727c9b1d882e@BSDforge.com> <A3FF2AF8-CAD9-4D0D-AFDE-3E1FCABD613E@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-02-09T02:31:19.000+01:00, Moin Rahman <bofh@freebsd.org> wrote: >> On Feb 9, 2024, at 2:25 AM, Chris <i.h8.git@BSDforge.com> wrote: >> >> On 2024-02-08 14:11, Daniel Engberg wrote: >> >>> The branch main has been updated by diizzy: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295 >>> >>> commit e2b4eb57621f1c96f678c210fe7d2474c904e295 >>> >>> Author: Daniel Engberg <diizzy@FreeBSD.org> >>> >>> AuthorDate: 2024-02-08 22:08:52 +0000 >>> >>> Commit: Daniel Engberg <diizzy@FreeBSD.org> >>> >>> CommitDate: 2024-02-08 22:09:19 +0000 >>> >>> graphics/pngcrush: Mark BROKEN and set expiration date to >>> 2024-02-29 >>> >>> Fails to build with libpng 1.6.41 due to usage of undocumented >>> feature to >>> >>> disable Adler32 checksums. >>> >>> Last release in 2017 and dead upstream, redirect users to >>> graphics/oxipng >>> >>> or graphics/pngquant >> >> This port is not broken. Please reverse this. >> >> If you, or anyone has an issue with the port. Use the bug >> reporting channel. >> >> That's what it is designed for. >> >>> Reference: >>> >>> https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5 >>> >>> PR: 276649 >>> >>> Reviewed by: Anton Saietskii <vsasjason@gmail.com> (maintainer) >>> >>> --- >>> >>> graphics/pngcrush/Makefile | 3 +++ >>> >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/graphics/pngcrush/Makefile >>> b/graphics/pngcrush/Makefile >>> >>> index 63e8ab2869d4..b38e9e664acc 100644 >>> >>> --- a/graphics/pngcrush/Makefile >>> >>> +++ b/graphics/pngcrush/Makefile >>> >>> @@ -14,6 +14,9 @@ LICENSE_NAME= Pngcrush License >>> >>> LICENSE_FILE= ${WRKSRC}/LICENSE >>> >>> LICENSE_PERMS= dist-mirror pkg-mirror auto-accept >>> >>> +BROKEN= Depends on undocumented feature to disable Adler32 >>> checksums, consider >>> >>> graphics/oxipng or graphics/pngquant >>> >>> +EXPIRATION_DATE=2024-02-29 >>> >>> + >>> >>> LIB_DEPENDS= libpng.so:graphics/png >>> [http://libpng.so:graphics/png] >>> >>> USES= cpe localbase:ldflags tar:xz > > Do you have a log that it builds with the newest libpng? https://pdr2.bofh.network/data/132-diizzy/2024-02-08_19h28m49s/logs/errors/pngcrush-1.8.13.log That's a fresh build Best regards, Daniel [-- Attachment #2 --] <div>On 2024-02-09T02:31:19.000+01:00, Moin Rahman <bofh@freebsd.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><blockquote class="ws-ng-quote"><div> On Feb 9, 2024, at 2:25 AM, Chris <<a class="defaultMailLink" href="mailto:i.h8.git@BSDforge.com">i.h8.git@BSDforge.com</a>> wrote:<br></div><div> <br></div><div> On 2024-02-08 14:11, Daniel Engberg wrote:<br></div><blockquote class="ws-ng-quote"><div> The branch main has been updated by diizzy:<br></div><div> URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295</a><br></div><div>; commit e2b4eb57621f1c96f678c210fe7d2474c904e295<br></div><div> Author: Daniel Engberg <<a class="defaultMailLink" href="mailto:diizzy@FreeBSD.org">diizzy@FreeBSD.org</a>><br></div><div> AuthorDate: 2024-02-08 22:08:52 +0000<br></div><div> Commit: Daniel Engberg <<a class="defaultMailLink" href="mailto:diizzy@FreeBSD.org">diizzy@FreeBSD.org</a>><br></div><div> CommitDate: 2024-02-08 22:09:19 +0000<br></div><div> graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29<br></div><div> Fails to build with libpng 1.6.41 due to usage of undocumented feature to<br></div><div> disable Adler32 checksums.<br></div><div> Last release in 2017 and dead upstream, redirect users to graphics/oxipng<br></div><div> or graphics/pngquant<br></div></blockquote><div> This port is not broken. Please reverse this.<br></div><div> If you, or anyone has an issue with the port. Use the bug reporting channel.<br></div><div> That's what it is designed for.<br></div><div> <br></div><blockquote class="ws-ng-quote"><div> Reference:<br></div><div> <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5" target="_blank">https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5</a><br></div><div>; PR: 276649<br></div><div> Reviewed by: Anton Saietskii <<a class="defaultMailLink" href="mailto:vsasjason@gmail.com">vsasjason@gmail.com</a>> (maintainer)<br></div><div> ---<br></div><div> graphics/pngcrush/Makefile | 3 +++<br></div><div> 1 file changed, 3 insertions(+)<br></div><div> diff --git a/graphics/pngcrush/Makefile b/graphics/pngcrush/Makefile<br></div><div> index 63e8ab2869d4..b38e9e664acc 100644<br></div><div> --- a/graphics/pngcrush/Makefile<br></div><div> +++ b/graphics/pngcrush/Makefile<br></div><div> @@ -14,6 +14,9 @@ LICENSE_NAME= Pngcrush License<br></div><div> LICENSE_FILE= ${WRKSRC}/LICENSE<br></div><div> LICENSE_PERMS= dist-mirror pkg-mirror auto-accept<br></div><div> +BROKEN= Depends on undocumented feature to disable Adler32 checksums, consider<br></div><div> graphics/oxipng or graphics/pngquant<br></div><div> +EXPIRATION_DATE=2024-02-29<br></div><div> +<br></div><div> LIB_DEPENDS= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://libpng.so:graphics/png" target="_blank">libpng.so:graphics/png</a><br></div><div> USES= cpe localbase:ldflags tar:xz<br></div></blockquote></blockquote><div> <br></div><div>Do you have a log that it builds with the newest libpng?<br></div></pre></blockquote></div><div><a href="https://pdr2.bofh.network/data/132-diizzy/2024-02-08_19h28m49s/logs/errors/pngcrush-1.8.13.log" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://pdr2.bofh.network/data/132-diizzy/2024-02-08_19h28m49s/logs/errors/pngcrush-1.8.13.log</a><br></div><div>That's a fresh build<br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div><div ><div><br></div></div><div><br></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?efdf6e20044a5e482e36ea7dfe7ca965>