Date: Mon, 25 Jan 2010 23:33:08 +0100 From: Antoine Brodin <antoine@FreeBSD.org> To: d@delphij.net Cc: Robert Watson <rwatson@freebsd.org>, freebsd-net@freebsd.org, delphij@freebsd.org, jhb@freebsd.org Subject: Re: [PATCH] Interface description Message-ID: <f19c444a1001251433v2ddca0a1g6dcb9e2aba8fb619@mail.gmail.com> In-Reply-To: <4B5E16DB.2080203@delphij.net> References: <4B5E16DB.2080203@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 25, 2010 at 11:10 PM, Xin LI <delphij@delphij.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> I have revised the patchset based on feedback received. This version:
>
> - Unbreak the case when libpcap is being built for pre-ifdescr world.
> - Documents the descr and -descr primitives for ifconfig(8), they are
> intended for OpenBSD compatibility.
> - Simplify and concentrate memory allocation in ifconfig(8)
> - Document the use of nul terminated buffer and the meaning of length
> parameter
> - Use char* instead of sbuf and simplify the logic in kernel part.
>
> Hopefully this version would address all problems raised by reviewers.
> Comments?
A few comments:
in contrib/libpcap/inet.c:
I think "int s;" can stay under #ifdef SIOCGIFDESCR
in sbin/ifconfig/ifconfig.c:
do {
...
if (...) {
descrlen *= 2;
continue;
}
...
} while (0);
I think there is no retry with larger buffer (while (0))
Perhaps you want while (1) + some breaks
Cheers,
Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f19c444a1001251433v2ddca0a1g6dcb9e2aba8fb619>