Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Jan 2024 23:15:42 +0100
From:      Daniel Engberg <daniel.engberg.lists@pyret.net>
To:        Mikhail Teterin <mi@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add  WhatsApp plugin for libpurple
Message-ID:  <f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com>
In-Reply-To: <202401202030.40KKUApC045320@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On 2024-01-20T21:30:10.000+01:00, Mikhail Teterin <mi@FreeBSD.org>
wrote:

> The branch main has been updated by mi:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=b430a140c818789ed59ac538a708df67be42fc2a
> 
> commit b430a140c818789ed59ac538a708df67be42fc2a
> 
> Author:     Mikhail Teterin <mi@FreeBSD.org>
> 
> AuthorDate: 2024-01-20 20:29:50 +0000
> 
> Commit:     Mikhail Teterin <mi@FreeBSD.org>
> 
> CommitDate: 2024-01-20 20:29:50 +0000
> 
>     net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple
> 
>     
> 
>     The bulk of the code is implemented in Go, and so some challenges remain.
> 
>     Help would be most welcome.
> 
> ---
> 
>  net-im/Makefile                                |  1 +
> 
>  net-im/purple-gowhatsapp/Makefile              | 49 ++++++++++++++++++++++++++
> 
>  net-im/purple-gowhatsapp/distinfo              |  3 ++
> 
>  net-im/purple-gowhatsapp/files/patch-configure | 27 ++++++++++++++
> 
>  net-im/purple-gowhatsapp/pkg-descr             |  5 +++
> 
>  net-im/purple-gowhatsapp/pkg-plist             |  5 +++
> 
>  6 files changed, 90 insertions(+)
> 
> diff --git a/net-im/Makefile b/net-im/Makefile
> 
> index e55c9365ebf8..63ce6b19620c 100644
> 
> --- a/net-im/Makefile
> 
> +++ b/net-im/Makefile
> 
> @@ -104,6 +104,7 @@
> 
>      SUBDIR += purple-discord
> 
>      SUBDIR += purple-facebook
> 
>      SUBDIR += purple-googlechat
> 
> +    SUBDIR += purple-gowhatsapp
> 
>      SUBDIR += purple-mattermost
> 
>      SUBDIR += purple-plugin-pack
> 
>      SUBDIR += purple-rocketchat
> 
> diff --git a/net-im/purple-gowhatsapp/Makefile b/net-im/purple-gowhatsapp/Makefile
> 
> new file mode 100644
> 
> index 000000000000..c04ecd199d16
> 
> --- /dev/null
> 
> +++ b/net-im/purple-gowhatsapp/Makefile
> 
> @@ -0,0 +1,49 @@
> 
> +PORTNAME=    purple-gowhatsapp
> 
> +DISTVERSIONPREFIX=v
> 
> +DISTVERSION=    1.13.0
> 
> +CATEGORIES=    net-im
> 
> +
> 
> +MAINTAINER=    mi@aldan.algebra.com
> 
> +COMMENT=    WhatsApp plugin for libpurple
> 
> +WWW=        https://github.com/hoehermann/purple-gowhatsapp
> 
> +
> 
> +LICENSE=    GPLv3
> 
> +LICENSE_FILE=    ${WRKSRC}/LICENSE
> 
> +
> 
> +LIB_DEPENDS=    libpurple.so:net-im/libpurple [http://libpurple.so:net-im/libpurple]    \
> 
> +        libopusfile.so:audio/opusfile [http://libopusfile.so:audio/opusfile]
> 
> +
> 
> +USES=    go:no_targets cmake dos2unix
> 
> +
> 
> +OPTIONS_MULTI=            DB-backend
> 
> +OPTIONS_MULTI_DB-backend=    SQLITE3 POSTGRES MYSQL
> 
> +OPTIONS_DEFAULT=SQLITE3
> 
> +.for o in ${OPTIONS_MULTI_DB}
> 
> +$o_DESC=    Support use of $o for storing account information
> 
> +.endfor
> 
> +
> 
> +USE_GITHUB=    yep...
> 
> +GH_ACCOUNT=    hoehermann
> 
> +DOS2UNIX_GLOB=    CMake*.txt
> 
> +
> 
> +CMAKE_ARGS=    -DPURPLE_INCLUDE_DIRS=${LOCALBASE}/include/libpurple    \
> 
> +        -DPURPLE_LIBRARY_DIRS=${LOCALBASE}/lib    \
> 
> +        -DPURPLE_PLUGIN_DIR=${PREFIX}/lib/purple-2 \
> 
> +        -DPURPLE_DATA_DIR=${PREFIX}/share
> 
> +LDFLAGS+=    -L${LOCALBASE}/lib
> 
> +
> 
> +post-patch-POSTGRES-off:
> 
> +    ${REINPLACE_CMD} '/lib\/pq/d' ${WRKSRC}/src/go/login.go
> 
> +
> 
> +post-patch-MYSQL-off:
> 
> +    ${REINPLACE_CMD} '/go-sql-driver\/mysql/d' ${WRKSRC}/src/go/login.go
> 
> +
> 
> +post-patch-SQLIT3-off:
> 
> +    ${REINPLACE_CMD} '/mattn\/go-sqlite3/d' ${WRKSRC}/src/go/login.go
> 
> +
> 
> +# The downloaded Go-files are read-only and the simple rm -f does not work
> 
> +# against them (unless invoked as root). Here we relax the permissions first:
> 
> +pre-clean:
> 
> +    -@${FIND} ${WRKDIR} | ${XARGS} ${CHMOD} u+w
> 
> +
> 
> +.include <bsd.port.mk> [http://bsd.port.mk>];
> 
> diff --git a/net-im/purple-gowhatsapp/distinfo b/net-im/purple-gowhatsapp/distinfo
> 
> new file mode 100644
> 
> index 000000000000..440dd580ed44
> 
> --- /dev/null
> 
> +++ b/net-im/purple-gowhatsapp/distinfo
> 
> @@ -0,0 +1,3 @@
> 
> +TIMESTAMP = 1705716803
> 
> +SHA256 (hoehermann-purple-gowhatsapp-v1.13.0_GH0.tar.gz) = 153229acd476ff1f98497074402944869c73e85ad06d6cfa8529bf4861960c96
> 
> +SIZE (hoehermann-purple-gowhatsapp-v1.13.0_GH0.tar.gz) = 140285
> 
> diff --git a/net-im/purple-gowhatsapp/files/patch-configure b/net-im/purple-gowhatsapp/files/patch-configure
> 
> new file mode 100644
> 
> index 000000000000..b8775407932d
> 
> --- /dev/null
> 
> +++ b/net-im/purple-gowhatsapp/files/patch-configure
> 
> @@ -0,0 +1,27 @@
> 
> +--- CMakeLists.txt    2023-09-01 16:15:26.000000000 -0400
> 
> ++++ CMakeLists.txt    2024-01-19 21:50:01.130852000 -0500
> 
> +@@ -4,3 +4,2 @@
> 
> + 
> 
> + set(Purple_DIR "${CMAKE_CURRENT_SOURCE_DIR}/submodules/purple-cmake" CACHE PATH "Where to find purple-config.cmake")
> 
> +-find_package(Purple REQUIRED)
> 
> +@@ -41,4 +40,2 @@
> 
> + 
> 
> + install(DIRECTORY "pixmaps" DESTINATION "${PURPLE_DATA_DIR}" FILES_MATCHING PATTERN "*.png")
> 
> +-
> 
> +-include(cpack.cmake)
> 
> +--- src/go/go.mod.in [http://go.mod.in]    2023-09-01 16:15:26.000000000 -0400
> 
> ++++ src/go/go.mod.in [http://go.mod.in]    2024-01-19 23:14:27.315646000 -0500
> 
> +@@ -2,13 +2,2 @@
> 
> + 
> 
> + go 1.18
> 
> +-
> 
> +-require (
> 
> +-    github.com/alfg/mp4 [http://github.com/alfg/mp4] v0.0.0-20210728035756-55ea58c08aeb
> 
> +-    github.com/go-sql-driver/mysql [http://github.com/go-sql-driver/mysql] v1.6.0
> 
> +-    github.com/lib/pq [http://github.com/lib/pq] v1.10.4
> 
> +-    github.com/mattn/go-sqlite3 [http://github.com/mattn/go-sqlite3] v1.14.10
> 
> +-    github.com/mdp/qrterminal/v3 [http://github.com/mdp/qrterminal/v3] v3.0.0
> 
> +-    github.com/skip2/go-qrcode [http://github.com/skip2/go-qrcode] v0.0.0-20200617195104-da1b6568686e
> 
> +-    golang.org/x/net [http://golang.org/x/net] v0.5.0 
> 
> +-    go.mau.fi/whatsmeow [http://go.mau.fi/whatsmeow] latest
> 
> +-)
> 
> diff --git a/net-im/purple-gowhatsapp/pkg-descr b/net-im/purple-gowhatsapp/pkg-descr
> 
> new file mode 100644
> 
> index 000000000000..89e601b1a08d
> 
> --- /dev/null
> 
> +++ b/net-im/purple-gowhatsapp/pkg-descr
> 
> @@ -0,0 +1,5 @@
> 
> +A libpurple/Pidgin plugin for WhatsApp.
> 
> +
> 
> +This is a re-write of purple-gowhatsapp, switching back-ends from
> 
> +go-whatsapp to whatsmeow. whatsmeow is written by Tulir Asokan. It
> 
> +has multi-device support.
> 
> diff --git a/net-im/purple-gowhatsapp/pkg-plist b/net-im/purple-gowhatsapp/pkg-plist
> 
> new file mode 100644
> 
> index 000000000000..b4b08ff3d299
> 
> --- /dev/null
> 
> +++ b/net-im/purple-gowhatsapp/pkg-plist
> 
> @@ -0,0 +1,5 @@
> 
> +lib/purple-2/libwhatsmeow.so [http://libwhatsmeow.so]
> 
> +share/pixmaps/pidgin/protocols/16/whatsapp.png
> 
> +share/pixmaps/pidgin/protocols/22/whatsapp.png
> 
> +share/pixmaps/pidgin/protocols/48/whatsapp.png
> 
> +share/pixmaps/pidgin/protocols/64/whatsapp.png

Hi,

Please at least enable DEVELOPER=yes and fix any warnings

Use the standard definition for POSTGRES, PGSQL

https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410

SQLITE option is broken

"post-patch-SQLIT3-off"

Overall ordering in Makefile can be improved, LDFLAGS can probably be
replaced with USES= localbase:ldflags

Configure logs suggests that USES= pkgconfig should be added

It also fails to build

https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log

If you're unsure please consider to create a review / PR instead of
just committing.

Please back this out for now.

Best regards,

Daniel


[-- Attachment #2 --]
<div>On 2024-01-20T21:30:10.000+01:00, Mikhail Teterin &lt;mi@FreeBSD.org&gt; wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by mi:<br></div><div><br></div><div>URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=b430a140c818789ed59ac538a708df67be42fc2a" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://cgit.FreeBSD.org/ports/commit/?id=b430a140c818789ed59ac538a708df67be42fc2a</a><br></div><div><br></div><div>commit b430a140c818789ed59ac538a708df67be42fc2a<br></div><div>Author:     Mikhail Teterin &lt;<a href="mailto:mi@FreeBSD.org" class="defaultMailLink">mi@FreeBSD.org</a>&gt;<br></div><div>AuthorDate: 2024-01-20 20:29:50 +0000<br></div><div>Commit:     Mikhail Teterin &lt;<a href="mailto:mi@FreeBSD.org" class="defaultMailLink">mi@FreeBSD.org</a>&gt;<br></div><div>CommitDate: 2024-01-20 20:29:50 +0000<br></div><div><br></div><div>    net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple<br></div><div>    <br></div><div>    The bulk of the code is implemented in Go, and so some challenges remain.<br></div><div>    Help would be most welcome.<br></div><div>---<br></div><div> net-im/Makefile                                |  1 +<br></div><div> net-im/purple-gowhatsapp/Makefile              | 49 ++++++++++++++++++++++++++<br></div><div> net-im/purple-gowhatsapp/distinfo              |  3 ++<br></div><div> net-im/purple-gowhatsapp/files/patch-configure | 27 ++++++++++++++<br></div><div> net-im/purple-gowhatsapp/pkg-descr             |  5 +++<br></div><div> net-im/purple-gowhatsapp/pkg-plist             |  5 +++<br></div><div> 6 files changed, 90 insertions(+)<br></div><div><br></div><div>diff --git a/net-im/Makefile b/net-im/Makefile<br></div><div>index e55c9365ebf8..63ce6b19620c 100644<br></div><div>--- a/net-im/Makefile<br></div><div>+++ b/net-im/Makefile<br></div><div>@@ -104,6 +104,7 @@<br></div><div>     SUBDIR += purple-discord<br></div><div>     SUBDIR += purple-facebook<br></div><div>     SUBDIR += purple-googlechat<br></div><div>+    SUBDIR += purple-gowhatsapp<br></div><div>     SUBDIR += purple-mattermost<br></div><div>     SUBDIR += purple-plugin-pack<br></div><div>     SUBDIR += purple-rocketchat<br></div><div>diff --git a/net-im/purple-gowhatsapp/Makefile b/net-im/purple-gowhatsapp/Makefile<br></div><div>new file mode 100644<br></div><div>index 000000000000..c04ecd199d16<br></div><div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowhatsapp/Makefile<br></div><div>@@ -0,0 +1,49 @@<br></div><div>+PORTNAME=	purple-gowhatsapp<br></div><div>+DISTVERSIONPREFIX=v<br></div><div>+DISTVERSION=	1.13.0<br></div><div>+CATEGORIES=	net-im<br></div><div>+<br></div><div>+MAINTAINER=	<a href="mailto:mi@aldan.algebra.com" class="defaultMailLink">mi@aldan.algebra.com</a><br></div><div>+COMMENT=	WhatsApp plugin for libpurple<br></div><div>+WWW=		<a href="https://github.com/hoehermann/purple-gowhatsapp" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://github.com/hoehermann/purple-gowhatsapp</a><br></div><div>+<br></div><div>+LICENSE=	GPLv3<br></div><div>+LICENSE_FILE=	${WRKSRC}/LICENSE<br></div><div>+<br></div><div>+LIB_DEPENDS=	<a href="http://libpurple.so:net-im/libpurple" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">libpurple.so:net-im/libpurple</a>	\<br></div><div>+		<a href="http://libopusfile.so:audio/opusfile" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">libopusfile.so:audio/opusfile</a><br></div><div>+<br></div><div>+USES=	go:no_targets cmake dos2unix<br></div><div>+<br></div><div>+OPTIONS_MULTI=			DB-backend<br></div><div>+OPTIONS_MULTI_DB-backend=	SQLITE3 POSTGRES MYSQL<br></div><div>+OPTIONS_DEFAULT=SQLITE3<br></div><div>+.for o in ${OPTIONS_MULTI_DB}<br></div><div>+$o_DESC=	Support use of $o for storing account information<br></div><div>+.endfor<br></div><div>+<br></div><div>+USE_GITHUB=	yep...<br></div><div>+GH_ACCOUNT=	hoehermann<br></div><div>+DOS2UNIX_GLOB=	CMake*.txt<br></div><div>+<br></div><div>+CMAKE_ARGS=	-DPURPLE_INCLUDE_DIRS=${LOCALBASE}/include/libpurple	\<br></div><div>+		-DPURPLE_LIBRARY_DIRS=${LOCALBASE}/lib	\<br></div><div>+		-DPURPLE_PLUGIN_DIR=${PREFIX}/lib/purple-2 \<br></div><div>+		-DPURPLE_DATA_DIR=${PREFIX}/share<br></div><div>+LDFLAGS+=	-L${LOCALBASE}/lib<br></div><div>+<br></div><div>+post-patch-POSTGRES-off:<br></div><div>+	${REINPLACE_CMD} '/lib\/pq/d' ${WRKSRC}/src/go/login.go<br></div><div>+<br></div><div>+post-patch-MYSQL-off:<br></div><div>+	${REINPLACE_CMD} '/go-sql-driver\/mysql/d' ${WRKSRC}/src/go/login.go<br></div><div>+<br></div><div>+post-patch-SQLIT3-off:<br></div><div>+	${REINPLACE_CMD} '/mattn\/go-sqlite3/d' ${WRKSRC}/src/go/login.go<br></div><div>+<br></div><div>+# The downloaded Go-files are read-only and the simple rm -f does not work<br></div><div>+# against them (unless invoked as root). Here we relax the permissions first:<br></div><div>+pre-clean:<br></div><div>+	-@${FIND} ${WRKDIR} | ${XARGS} ${CHMOD} u+w<br></div><div>+<br></div><div>+.include &lt;<a href="http://bsd.port.mk>" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">bsd.port.mk&gt;</a>;<br></div><div>diff --git a/net-im/purple-gowhatsapp/distinfo b/net-im/purple-gowhatsapp/distinfo<br></div><div>new file mode 100644<br></div><div>index 000000000000..440dd580ed44<br></div><div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowhatsapp/distinfo<br></div><div>@@ -0,0 +1,3 @@<br></div><div>+TIMESTAMP = 1705716803<br></div><div>+SHA256 (hoehermann-purple-gowhatsapp-v1.13.0_GH0.tar.gz) = 153229acd476ff1f98497074402944869c73e85ad06d6cfa8529bf4861960c96<br></div><div>+SIZE (hoehermann-purple-gowhatsapp-v1.13.0_GH0.tar.gz) = 140285<br></div><div>diff --git a/net-im/purple-gowhatsapp/files/patch-configure b/net-im/purple-gowhatsapp/files/patch-configure<br></div><div>new file mode 100644<br></div><div>index 000000000000..b8775407932d<br></div><div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowhatsapp/files/patch-configure<br></div><div>@@ -0,0 +1,27 @@<br></div><div>+--- CMakeLists.txt	2023-09-01 16:15:26.000000000 -0400<br></div><div>++++ CMakeLists.txt	2024-01-19 21:50:01.130852000 -0500<br></div><div>+@@ -4,3 +4,2 @@<br></div><div>+ <br></div><div>+ set(Purple_DIR "${CMAKE_CURRENT_SOURCE_DIR}/submodules/purple-cmake" CACHE PATH "Where to find purple-config.cmake")<br></div><div>+-find_package(Purple REQUIRED)<br></div><div>+@@ -41,4 +40,2 @@<br></div><div>+ <br></div><div>+ install(DIRECTORY "pixmaps" DESTINATION "${PURPLE_DATA_DIR}" FILES_MATCHING PATTERN "*.png")<br></div><div>+-<br></div><div>+-include(cpack.cmake)<br></div><div>+--- src/go/<a href="http://go.mod.in" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">go.mod.in</a>	2023-09-01 16:15:26.000000000 -0400<br></div><div>++++ src/go/<a href="http://go.mod.in" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">go.mod.in</a>	2024-01-19 23:14:27.315646000 -0500<br></div><div>+@@ -2,13 +2,2 @@<br></div><div>+ <br></div><div>+ go 1.18<br></div><div>+-<br></div><div>+-require (<br></div><div>+-	<a href="http://github.com/alfg/mp4" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">github.com/alfg/mp4</a> v0.0.0-20210728035756-55ea58c08aeb<br></div><div>+-	<a href="http://github.com/go-sql-driver/mysql" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">github.com/go-sql-driver/mysql</a> v1.6.0<br></div><div>+-	<a href="http://github.com/lib/pq" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">github.com/lib/pq</a> v1.10.4<br></div><div>+-	<a href="http://github.com/mattn/go-sqlite3" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">github.com/mattn/go-sqlite3</a> v1.14.10<br></div><div>+-	<a href="http://github.com/mdp/qrterminal/v3" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">github.com/mdp/qrterminal/v3</a> v3.0.0<br></div><div>+-	<a href="http://github.com/skip2/go-qrcode" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">github.com/skip2/go-qrcode</a> v0.0.0-20200617195104-da1b6568686e<br></div><div>+-	<a href="http://golang.org/x/net" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">golang.org/x/net</a> v0.5.0 <br></div><div>+-	<a href="http://go.mau.fi/whatsmeow" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">go.mau.fi/whatsmeow</a> latest<br></div><div>+-)<br></div><div>diff --git a/net-im/purple-gowhatsapp/pkg-descr b/net-im/purple-gowhatsapp/pkg-descr<br></div><div>new file mode 100644<br></div><div>index 000000000000..89e601b1a08d<br></div><div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowhatsapp/pkg-descr<br></div><div>@@ -0,0 +1,5 @@<br></div><div>+A libpurple/Pidgin plugin for WhatsApp.<br></div><div>+<br></div><div>+This is a re-write of purple-gowhatsapp, switching back-ends from<br></div><div>+go-whatsapp to whatsmeow. whatsmeow is written by Tulir Asokan. It<br></div><div>+has multi-device support.<br></div><div>diff --git a/net-im/purple-gowhatsapp/pkg-plist b/net-im/purple-gowhatsapp/pkg-plist<br></div><div>new file mode 100644<br></div><div>index 000000000000..b4b08ff3d299<br></div><div>--- /dev/null<br></div><div>+++ b/net-im/purple-gowhatsapp/pkg-plist<br></div><div>@@ -0,0 +1,5 @@<br></div><div>+lib/purple-2/<a href="http://libwhatsmeow.so" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">libwhatsmeow.so</a><br></div><div>+share/pixmaps/pidgin/protocols/16/whatsapp.png<br></div><div>+share/pixmaps/pidgin/protocols/22/whatsapp.png<br></div><div>+share/pixmaps/pidgin/protocols/48/whatsapp.png<br></div><div>+share/pixmaps/pidgin/protocols/64/whatsapp.png<br></div></pre></blockquote></div><div><div>Hi,<br></div><div><div><br></div></div><div>Please at least enable DEVELOPER=yes and fix any warnings<br></div><div><div><br></div></div><div>Use the standard definition for POSTGRES, PGSQL<br></div><div><a href="https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410</a><br></div><div><div><br></div></div><div>SQLITE option is broken<br></div><div>"post-patch-SQLIT3-off"<br></div><div><div><br></div></div><div>Overall ordering in Makefile can be improved, LDFLAGS can probably be replaced with USES= localbase:ldflags<br></div><div><div><br></div><div>Configure logs suggests that USES= pkgconfig should be added<br></div><div><br></div></div><div>It also fails to build<br></div><div><div><br></div></div><div><a href="https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log</a><br></div><div><div><br></div></div><div>If you're unsure please consider to create a review / PR instead of just committing.<br></div><div><div><br></div></div><div>Please back this out for now.<br></div><div><div><br></div></div><div>Best regards,<br></div><div>Daniel<br></div></div>

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f22ba5fb94cbee57ef6dbac2bdb3db87>