Date: Thu, 10 May 2018 17:34:07 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Dries Michiels <driesm.michiels@gmail.com>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Re: kernel: in6_delayed_cksum: delayed m_pullup Message-ID: <f537f8b4-07ad-8202-a17d-8b4a71aabe93@yandex.ru> In-Reply-To: <c4953cdd-faf9-21ac-1b1b-2fba817d0a2c@yandex.ru> References: <5ae60f44.1c69fb81.ee4a5.1043@mx.google.com> <c4953cdd-faf9-21ac-1b1b-2fba817d0a2c@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--U0lLuzNwU6thpb7Si8HV35u2JwnV3rKmQ
Content-Type: multipart/mixed; boundary="phJWaPev3c5prtHCArkqd18jYMryBM7T2";
protected-headers="v1"
From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: Dries Michiels <driesm.michiels@gmail.com>,
"freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
Message-ID: <f537f8b4-07ad-8202-a17d-8b4a71aabe93@yandex.ru>
Subject: Re: kernel: in6_delayed_cksum: delayed m_pullup
References: <5ae60f44.1c69fb81.ee4a5.1043@mx.google.com>
<c4953cdd-faf9-21ac-1b1b-2fba817d0a2c@yandex.ru>
In-Reply-To: <c4953cdd-faf9-21ac-1b1b-2fba817d0a2c@yandex.ru>
--phJWaPev3c5prtHCArkqd18jYMryBM7T2
Content-Type: multipart/mixed;
boundary="------------9E47AE9791B592152C151262"
Content-Language: en-US
This is a multi-part message in MIME format.
--------------9E47AE9791B592152C151262
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
On 10.05.2018 17:25, Andrey V. Elsukov wrote:
> On 29.04.2018 21:30, Dries Michiels wrote:
>> Dear mailing list,
>>
>> After upgrading my FreeBSD server from source from:
>> FreeBSD 11.1-STABLE (VADOS) #9 r331859: Sun Apr 1 12:09:18 CEST 2018 =
>> to
>> FreeBSD 11.2-PRERELEASE (VADOS) #10 r333091: Sun Apr 29 16:48:44 CEST =
2018
>>
>> My /var/log/messages is getting spammed by the following notice/error:=
>> Apr 29 19:51:42 vados kernel: in6_delayed_cksum: delayed m_pullup, m->=
len: 48 plen 68 off 56 csum_flags=3D400<CSUM_IP6_TCP>
>> Apr 29 19:55:34 vados last message repeated 11 times
>> Apr 29 20:11:56 vados last message repeated 10 times
>> Apr 29 20:12:42 vados last message repeated 4 times
>>
>> Does anyone have a clue what this indicates?
>> I did not have this message on my older system (r331859).
>=20
> Do you use pf(4) or ipsec(4)?
Also, can you try this patch?
--=20
WBR, Andrey V. Elsukov
--------------9E47AE9791B592152C151262
Content-Type: text/x-patch;
name="in6_delayed_cksum.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="in6_delayed_cksum.diff"
Index: sys/netinet6/ip6_output.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/netinet6/ip6_output.c (revision 333456)
+++ sys/netinet6/ip6_output.c (working copy)
@@ -199,18 +199,10 @@ in6_delayed_cksum(struct mbuf *m, uint32_t plen, u
csum =3D 0xffff;
offset +=3D m->m_pkthdr.csum_data; /* checksum offset */
=20
- if (offset + sizeof(u_short) > m->m_len) {
- printf("%s: delayed m_pullup, m->len: %d plen %u off %u "
- "csum_flags=3D%b\n", __func__, m->m_len, plen, offset,
- (int)m->m_pkthdr.csum_flags, CSUM_BITS);
- /*
- * XXX this should not happen, but if it does, the correct
- * behavior may be to insert the checksum in the appropriate
- * next mbuf in the chain.
- */
- return;
- }
- *(u_short *)(m->m_data + offset) =3D csum;
+ if (offset + sizeof(csum) > m->m_len)
+ m_copyback(m, offset, sizeof(csum), &csum);
+ else
+ *(u_short *)mtodo(m, offset) =3D csum;
}
=20
int
--------------9E47AE9791B592152C151262--
--phJWaPev3c5prtHCArkqd18jYMryBM7T2--
--U0lLuzNwU6thpb7Si8HV35u2JwnV3rKmQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlr0WF8ACgkQAcXqBBDI
oXqY3Qf8DNH1cB4A0iHCq1FXiOm/KdPChgrDj8ErSqmPBnnrmfYaj7X4XbxC7Kzf
/q2wVTNrmnxrMTINzORuSdWSNIAW/DRZUOH5zH/alp2hLearS/TSzvdmviPDj7Qw
NwfyGnLmNPblsszqbVBbmFScOCYUIhLLCONOBJVNdRTCUGSp1MzCr0YSn0U9me7o
/LYnEG1pYNxpKA00fA/i2hKIT00eavFPI+lrekIDvLb4geZLKWnFjnAbQkiiNTiD
TWXpHrHnhr9AQWuOncSJ07OMN0VQ21zRDSbOqfmuADABxZSTFmijUH8SWQ3mknVV
v4j8nvPByQ5sbd6Xv/Njpmz8rYjwrw==
=6Vil
-----END PGP SIGNATURE-----
--U0lLuzNwU6thpb7Si8HV35u2JwnV3rKmQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f537f8b4-07ad-8202-a17d-8b4a71aabe93>