Date: Mon, 25 Oct 2010 22:33:51 +0200 From: Ivan Voras <ivoras@freebsd.org> To: freebsd-current@freebsd.org Subject: Re: [RFC] More meaningful information about ENOEXEC for kldload(8) Message-ID: <ia4pjg$650$1@dough.gmane.org> In-Reply-To: <AANLkTindYRwpmA=En%2BpYyHVcUkmQ0wsZrB7Y-f2E=vK=@mail.gmail.com> References: <4CC5D83E.8030505@delphij.net> <4CC5D9DB.1020409@FreeBSD.org> <AANLkTindYRwpmA=En%2BpYyHVcUkmQ0wsZrB7Y-f2E=vK=@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/25/10 22:13, Garrett Cooper wrote: > On Mon, Oct 25, 2010 at 12:26 PM, Doug Barton<dougb@freebsd.org> wrote: >> On 10/25/2010 12:19, Xin LI wrote: >>> >>> Here is a simple patch that adds more meaning messages when kldload hits >>> ENOEXEC. >> >> +1 on anything that makes this (and related) error more clear. I know I've >> stumbled over it numerous times. > > Typo in the error message aside... > Technically you can dig the source of these errors from > /var/log/messages // syslog though, Yes... > so why not just keep status quo? And no :) I've often encountered the kldload failure and I've always had to look at the kernel logs to find out the actual reason. There are several cases where kldload can fail, including recursively - when a module fails to load as a dependancy of the module the user is trying to load, for all the reasons a module can fail to load. I think something should be done to make the message more descriptive but statically changing the error message isn't it (except if the message is changed to say "please look at the kernel syslog messages to find out the real reason for this failure"). The best version would be to export more data about what exactly was the failure and where it happened.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ia4pjg$650$1>