Date: Sat, 10 Apr 2010 03:18:42 -0700 From: Garrett Cooper <yanefbsd@gmail.com> To: Dominic Fandrey <kamikaze@bsdforen.de> Cc: freebsd-ports@freebsd.org Subject: Re: Trivial PR, fix package-noinstall Message-ID: <t2p7d6fde3d1004100318k8b0b622fpaa38c5d942d8d60a@mail.gmail.com> In-Reply-To: <4BC04503.4000808@bsdforen.de> References: <4BC04503.4000808@bsdforen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 10, 2010 at 2:29 AM, Dominic Fandrey <kamikaze@bsdforen.de> wrote: > This morning I took a look at my outstanding PRs. There are > is a ports PR I consider old and trivial: > > This one fixes a bug in the package-noinstall target. wxs told > me that he prefers my proposed fix over his own: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144164 This suggested fix completely breaks pkg_creates operation because it does a chdir(2) prior to package creation (from .../usr.sbin/pkg_install/create/perform.c:555): if (chdir(log_dir) == FAIL) { warnx("can't change directory to '%s'!", log_dir); return FALSE; } The goal is to expand use of the install and deinstall scripts, not break them in ports; this would be counterproductive to what we want to do. FWIW, I've thought this over and and user modifiable scripts should not be in packages; they should instead be example files which don't conflict with real configuration files. This is already the case for several ports, but not all ports. If we did this, it would solve the problem we've had with ports removing or overwriting user config files simply and easily. I wonder if other folks agree with me or not. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?t2p7d6fde3d1004100318k8b0b622fpaa38c5d942d8d60a>