Date: Fri, 06 Apr 2012 15:59:43 +0200 From: Bengt Ahlgren <bengta@sics.se> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: freebsd-geom@FreeBSD.org Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole unit! Message-ID: <uh7k41tt0z4.fsf@P142.sics.se> In-Reply-To: <4F7E72D7.6040501@FreeBSD.org> (Andrey V. Elsukov's message of "Fri, 06 Apr 2012 08:36:39 %2B0400") References: <201204052210.q35MA5gt065889@freefall.freebsd.org> <4F7E72D7.6040501@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
"Andrey V. Elsukov" <ae@FreeBSD.org> writes: > On 06.04.2012 2:10, Bengt Ahlgren wrote: >> bsdlabel: partition c doesn't cover the whole unit! >> bsdlabel: An incorrect partition c may cause problems for standard system utilities >> >> I added a printout of the value bsdlabel compares with: >> >> bsdlabel: partition c doesn't cover the whole unit! 1953525168 >> >> This number corresponds to the size of the whole disk, not the size of >> the slice, so lp->d_secperunit is not the right variable to use, or is >> incorrectly set. >> >> Finally, I stepped back to r220455 (in stable/8). That version of >> bsdlabel did not complain, so it seems that r227564 by ae (cc:d) is >> causing, or making visible, this problem. > > Hi, > > Thank you for your report. Yes, r227564 has made visible a known sysinstall's bug. > GEOM_PART_BSD already has quirk that automatically fixes it, can you try attached patch? The patch does fix the issue with bsdlabel - thanks! I am however curious to why you refer to a sysinstall bug. I did not use sysinstall to create the partitions. Bengt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?uh7k41tt0z4.fsf>