Date: 20 Feb 2001 14:48:02 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: Peter Pentchev <roam@orbitel.bg> Cc: Neil Blakey-Milner <nbm@FreeBSD.org>, Tony Finch <dot@dotat.at>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/Tools/scripts/mkptools mkpbuild mkpinstall Message-ID: <xzp8zn1jwj1.fsf@flood.ping.uio.no> In-Reply-To: Peter Pentchev's message of "Tue, 20 Feb 2001 15:23:13 %2B0200" References: <200101031116.f03BGlq39072@freefall.freebsd.org> <20010103141000.B54743@ringworld.oblivion.bg> <20010103142157.D54743@ringworld.oblivion.bg> <20010220152313.A47687@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Pentchev <roam@orbitel.bg> writes:
> +my $path_tmp = "/tmp";
> +eval {
> + require 'paths.ph';
> + $path_tmp = &_PATH_TMP;
> +};
There's no point in using eval if you're not going to handle the case
where the 'require' fails. Either remove the eval { } or, add some
sort of error handling (conditional on $@ being defined).
DES
--
Dag-Erling Smorgrav - des@ofug.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzp8zn1jwj1.fsf>