Date: Mon, 03 Feb 2003 20:50:30 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: phk@freebsd.org Cc: Gordon Tetlow <gordon@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom geom_vol_ffs.c Message-ID: <xzphebl6t4p.fsf@flood.ping.uio.no> In-Reply-To: <11633.1044300113@critter.freebsd.dk> (phk@freebsd.org's message of "Mon, 03 Feb 2003 20:21:53 %2B0100") References: <11633.1044300113@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
A couple of comments to vol_ffs: - I had to reboot for the volume names to actually appear in /dev/vol. - I was unable to set a volume name on my root partition. I tried 'tunefs -L root /dev/ad0a' in single-user mode, before mounting anything. It did not show up in /dev/vol, even after a reboot. - Although tunefs(8) won't let you set a volume label containing anything but alphanumerics (IMHO, it should accept underscores as well), there's nothing in g_vol_ffs_taste() that checks for invalid characters in the label. What happens if I manually edit the superblock and put a / in there? (imagine inserting a borrowed Zip disk and boom...) - I would be very happy if the device nodes in /dev/vol/ were actually symlinks to the underlying device - provided that's possible without introducing major ugliness into the code. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzphebl6t4p.fsf>