Date: Mon, 20 Feb 2006 20:15:57 +0900 From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?= <jinmei@isl.rdc.toshiba.co.jp> To: Craig Boston <craig@olyun.gank.org> Cc: freebsd-net@freebsd.org Subject: Re: Race condition in ip6_getpmtu (actually gif)? Message-ID: <y7v4q2u1dsi.wl%jinmei@isl.rdc.toshiba.co.jp> In-Reply-To: <20060127020528.GA18728@nowhere> References: <20060125152032.GA40581@nowhere> <20060127020528.GA18728@nowhere>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>>> On Thu, 26 Jan 2006 20:05:28 -0600, >>>>> Craig Boston <craig@olyun.gank.org> said: >> I seem to be running into a race condition in ip6_getpmtu. I've been >> having sporadic panics recently -- sometimes the machine will last a >> week, sometimes it'll panic twice in a day. The backtrace is always the >> same: (snip) > Attached is a quick hack to protect the cached route with a mutex. A > better fix with less overhead would be to allocate the route in a local > variable on the stack, and only copy it to the softc if route caching is > enabled. I'll run for a couple weeks with the patch and file a PR if > that fixes it. I guess this problem was fixed with the following changes: http://www.jp.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_gif.c.diff?r1=1.57&r2=1.58 http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/in6_gif.c.diff?r1=1.23&r2=1.24 But I'll be happy to look at the problem more closely if not. JINMEI, Tatuya Communication Platform Lab. Corporate R&D Center, Toshiba Corp. jinmei@isl.rdc.toshiba.co.jp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y7v4q2u1dsi.wl%jinmei>