Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Oct 2004 12:29:19 +0900
From:      JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?= <jinmei@isl.rdc.toshiba.co.jp>
To:        freebsd-current@freebsd.org
Subject:   minor typo in sys/kern/uipc_socket2.c
Message-ID:  <y7vsm80j0ts.wl@ocean.jinmei.org>

next in thread | raw e-mail | index | archive | help
FreeBSD current (and the 5.3 branch) needs the following patch.
Otherwise, it always consumes mbuf cluster for cmsg items even when
unnecessary.

(I should probably file a PR for this, but I currently do not have a
good access to the PR system.  So please forgive me to send this to
the list.)

					JINMEI, Tatuya
					Communication Platform Lab.
					Corporate R&D Center, Toshiba Corp.
					jinmei@isl.rdc.toshiba.co.jp

Index: uipc_socket2.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/uipc_socket2.c,v
retrieving revision 1.137
diff -u -r1.137 uipc_socket2.c
--- uipc_socket2.c	15 Aug 2004 06:24:41 -0000	1.137
+++ uipc_socket2.c	27 Oct 2004 03:26:48 -0000
@@ -1253,7 +1253,7 @@
 
 	if (CMSG_SPACE((u_int)size) > MCLBYTES)
 		return ((struct mbuf *) NULL);
-	if (CMSG_SPACE((u_int)size > MLEN))
+	if (CMSG_SPACE((u_int)size) > MLEN)
 		m = m_getcl(M_DONTWAIT, MT_CONTROL, 0);
 	else
 		m = m_get(M_DONTWAIT, MT_CONTROL);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y7vsm80j0ts.wl>