Date: Sun, 03 Nov 2002 09:17:26 +0100 From: Michael Bretterklieber <mbretter@inode.at> To: freebsd-net@freebsd.org Cc: brian@freebsd.org Subject: ppp radius programmer question Message-ID: <3DC4DB96.9070402@inode.at>
next in thread | raw e-mail | index | archive | help
Hi,
I'm implementing radius for mpd and I found maybe a leak in radius.c of
the userland-ppp.
in the function radius_Process, I think there is a missing free function
call:
snip
case RAD_MICROSOFT_MS_MPPE_RECV_KEY:
free(r->mppe.recvkey);
demangle(r, data, len, &r->mppe.recvkey, &r->mppe.recvkeylen);
log_Printf(LogPHASE, " MS-MPPE-Recv-Key ********\n");
break;
case RAD_MICROSOFT_MS_MPPE_SEND_KEY:
<--- isn't here missing: free(r->mppe.sendkey); -->
demangle(r, data, len, &r->mppe.sendkey, &r->mppe.sendkeylen);
log_Printf(LogPHASE, " MS-MPPE-Send-Key ********\n");
break;
Am I right or is this just a bug in my brain?
bye,
--
------------------------------- ----------------------------------
Michael Bretterklieber - Michael.Bretterklieber@jawa.at JAWA
Management Software GmbH - http://www.jawa.at
Liebenauer Hauptstr. 200 -------------- privat ------------
A-8041 GRAZ GSM: ++43-(0)676-93 96 698 Tel:
++43-(0)316-403274-12 E-mail: mbretter@inode.at
Fax: ++43-(0)316-403274-10 http://www.inode.at/mbretter
------------------------------- ----------------------------------
"...the number of UNIX installations has grown to 10, with more
expected..." - Dennis Ritchie and Ken Thompson, June 1972
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3DC4DB96.9070402>