Date: Tue, 15 Apr 2003 09:12:09 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: mdodd@FreeBSD.ORG Cc: arch@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c Message-ID: <20030415.091209.108403664.imp@bsdimp.com> In-Reply-To: <20030415104824.H99028@sasami.jurai.net> References: <20030415102955.S99028@sasami.jurai.net> <20030415.083615.91276433.imp@bsdimp.com> <20030415104824.H99028@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[[ moved to arch ]]
In message: <20030415104824.H99028@sasami.jurai.net>
"Matthew N. Dodd" <mdodd@FreeBSD.ORG> writes:
: On Tue, 15 Apr 2003, M. Warner Losh wrote:
: > How do you tell if a BAR is enabled? I assume you mean 'check to see
: > if the BAR has an allocated resource' here? In that case, my XXX
: > applies :-( We should allocate a resonable resource.
:
: Actually I misspoke; we should modify pci_enable_io_method() so that we
: can indicate a failure to enable the requested space.
foo |= BIT;
if ((foo & BIT) == 0)
whine-and-fail;
is that what you are saying?
: This would keep drivers from having to check and see if PCIM_CMD_PORTEN or
: PCIM_CMD_MEMEN is set.
Yes.
: This requires changing the definition of the 'enable_io' method.
:
: Since we're here we should change 'disable_io' and
: '{enable,disable}_busmaster' as well.
If we're going to do this, then we need to do it soon.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030415.091209.108403664.imp>